Skip to content

Fix graphs not allowing grouping with no date (D1682) #636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
droberts-ctrlo wants to merge 1 commit into from
Closed

Fix graphs not allowing grouping with no date (D1682) #636

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/GADS/Graph.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -411,7 +411,7 @@ sub write
error __"Dates and grouping must be entered for a custom range"
if $x_axis_col && $x_axis_col->return_type =~ /date/
&& $newgraph->{x_axis_range} && $newgraph->{x_axis_range} eq 'custom'
&& (!$newgraph->{from} || !$newgraph->{to} || !$newgraph->{x_axis_grouping});
&& (!$newgraph->{x_axis_grouping});

error __"A single field must be selected for the x-axis when using the historic trend option"
if !$newgraph->{x_axis} && $self->trend;
Expand Down
Loading