Admin Events Dashboard: Submitted Events Do Not Appear - #178
Merged
Conversation
The admin events dashboard called getAdminEvents() but the admin router only had POST/PUT/DELETE, so submitted events never appeared in the list. (#165)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The admin Events page calls
GET /api/admin/eventsto populate its table. This route did not exist -- the admin events router only definedPOST,PUT, andDELETE-- so the request 405'd, the error was caught silently, and the table always rendered empty even after events were successfully created.Changes:
GET /api/admin/eventsroute returning all events (published and unpublished), protected byget_current_user, sorted bystart_datetime, usingAdminCalendarEventDTOGET /api/eventsroute (which filters tois_published == true) unchangedCloses #165