Skip to content

Update testPoissonAccuracy.m#376

Merged
jbrzensk merged 2 commits into
mainfrom
matlab_test/FixPoissonAccuracyTest
May 27, 2026
Merged

Update testPoissonAccuracy.m#376
jbrzensk merged 2 commits into
mainfrom
matlab_test/FixPoissonAccuracyTest

Conversation

@Tony-Drummond
Copy link
Copy Markdown
Collaborator

I removed 8th order test

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Example
  • Documentation

Description

Current test implementation prevents a known error from occurring in the Poisson Accuracy test by commenting the 8th order tests case in the code. This should be reviewed in the future.

Related Issues & Documents

QA Instructions, Screenshots, Recordings

Keep-open request

  • I am requesting maintainer review for keep-open.

Reason:

Added/updated tests?

_We encourage you to test all code included with MOLE, including examples.

  • Yes (this code is a test)
  • No, and this is why: please replace this line with details on why tests
    have not been included
  • I need help with writing tests

Read Contributing Guide and Code of Conduct

[optional] Are there any post deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

remove 8th order test
Copy link
Copy Markdown
Collaborator

@jbrzensk jbrzensk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, does the test actually run?
@cpaolini pull request was merged, but everything shows as passing?

Image

Is the previous issue fixed?

Comment thread tests/matlab_octave/testPoissonAccuracy.m Outdated
@Tony-Drummond
Copy link
Copy Markdown
Collaborator Author

The testPoissonAccuracy.m successfully runs (excluding the case k=8)

Screen Shot 2026-05-26 at 3 39 03 PM

@Tony-Drummond
Copy link
Copy Markdown
Collaborator Author

Tony-Drummond commented May 26, 2026

@jbrzensk there were three different issues, in Issue #361 @Jiya-Rathi reported that the matlab_tests were not even running and the issue had to do with the directory path. This issue was closed with PR #374.

The second issue was related to the 8th order for the testPoissonAccuracy.m tests, which was reported in Issue#321 and that is solved with the PR # 376.

And the last issue, which is still not solved, is why is the GitHub actions not catching the MATLAB errors in the build tests. As you can see above when we run the tests manually, they do failed or run successfully. The former failed cases are not being caught by the build system.

We are now opening a new issue, which will focus on the last issue and tag @cpaolini for help with it.

@Jiya-Rathi
Copy link
Copy Markdown
Collaborator

I have opened the issue mentioned by @Tony-Drummond in issue #377

@jbrzensk jbrzensk merged commit 7a25117 into main May 27, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Question about Poisson Accuracy Test

3 participants