chore(actions): replace deployment PAT with app dispatch#222
Merged
Conversation
Member
Author
|
Superseded by #224, which includes the same dispatch-action migration plus distinct qa/ptb image names to avoid cross-environment deployment updates. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use the shared
deployment-dispatch-actionin.github/workflows/docker.ymlinstead of directly checking out and editingcsesoc/deploymentfrom this repo's workflow.Changes
devsoc-unsw/deployment-dispatch-action@mainvars.DEPLOYMENT_DISPATCHER_APP_IDandsecrets.DEPLOYMENT_DISPATCHER_APP_PRIVATE_KEYgithub.tokenGH_TOKENand old image-updater references from the repoGH_TOKENContext
This uses the shared
devsoc-unsw/deployment-dispatch-actionwith explicit target inputs forcsesoc/deploymentondevelop, becausecsesoc/deployment-dispatch-actiondoes not exist.Verification
rg -n "\\bGH_TOKEN\\b|\\bIMAGE_UPDATER_APP_ID\\b|\\bIMAGE_UPDATER_APP_PRIVATE_KEY\\b" . -S -g '!node_modules'returns no matchesactionlint -color .github/workflows/docker.ymlstill reports pre-existing baseline issues for old major action refs and the missingsteps.metadefinitioncsesoc/deploymenthas.github/workflows/dispatch-image-update.ymlon its default branch and that its manifest matcher acceptsghcr.io/csesoc/projects-discord-bot