Fixes issue # 54: IoManager._get_responses_windows mangles token when reading from stdout#55
Closed
leonardopsantos wants to merge 10 commits into
Closed
Fixes issue # 54: IoManager._get_responses_windows mangles token when reading from stdout#55leonardopsantos wants to merge 10 commits into
IoManager._get_responses_windows mangles token when reading from stdout#55leonardopsantos wants to merge 10 commits into
Conversation
added 10 commits
May 17, 2021 20:31
…esponses_windows.
Owner
|
Hey, sorry for the ridiculously delayed reply, and thanks for taking the time to contribute. Would you be interested in updating this to fix the merge conflict and make the CI tests pass? I will give you a quick review (within a few days) if you choose to. |
Owner
|
I like that stack overflow answer. Getting rid of OS-specific stuff would be nice. |
Collaborator
|
As the patch was not updated, I can take this and rebased it against |
Author
|
Sorry for the super late reply. I'd appreciate it if anyone could rebase this as I switched jobs and no longer have access to a Windows system. |
barisione
pushed a commit
to barisione/pygdbmi
that referenced
this pull request
Aug 13, 2022
Original patch by Leonardo Pereira Santos (see cs01#55); updated by Marco Barisione.
1 task
Collaborator
|
I made a separate PR (#76) to update this (as I cannot push to somebody else's repository). Tests don't pass on Unix and I'm reluctant to modify the code as I cannot test it on Windows. |
barisione
pushed a commit
to barisione/pygdbmi
that referenced
this pull request
Aug 14, 2022
Original patch by Leonardo Pereira Santos (see cs01#55); updated by Marco Barisione.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUPERSEDED BY #76
CHANGELOG.mdSummary of changes
Fixes issue #54
Removed the
make_non_blockingfunction. Refactored the_get_responses_windowsmethod to use separate threads and queues to make reading non-blocking. solution based on this StackOverflow answerTest plan
Executed unit tests: