Skip to content

Xtyll/return on first response#100

Open
Xtyll wants to merge 3 commits into
cs01:masterfrom
Xtyll:xtyll/return_on_first_response
Open

Xtyll/return on first response#100
Xtyll wants to merge 3 commits into
cs01:masterfrom
Xtyll:xtyll/return_on_first_response

Conversation

@Xtyll

@Xtyll Xtyll commented Jul 22, 2023

Copy link
Copy Markdown
  • [] I have added parameter return_on_first_response to write and get_response methods. With this parameter GbdController return the first received response without adidtional waiting

Summary of changes

Test plan

Tested by running

nox -s tests

The separate test added (test_return_on_first_response). The test set timeout to 10s without additional delay and perform one simple stepi operation. To test pass we expect that response will generated faster than defined timeout

@Xtyll

Xtyll commented Jul 22, 2023

Copy link
Copy Markdown
Author

@cs01 @barisione could you check it please?

@barisione

Copy link
Copy Markdown
Collaborator

I'm not really familiar with gdbcontroller and friends so @cs01 would be better (if you can find the time for it!).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants