Remove NVIDIA CUDA classifier to fix node pack loading issue#275
Open
gregory-richard wants to merge 1 commit into
Open
Remove NVIDIA CUDA classifier to fix node pack loading issue#275gregory-richard wants to merge 1 commit into
gregory-richard wants to merge 1 commit into
Conversation
The `Environment :: GPU :: NVIDIA CUDA` classifier in pyproject.toml causes ComfyUI's node pack validation to treat NVIDIA CUDA as a hard requirement. This prevents the extension from loading entirely on systems where the reported accelerator string doesn't exactly match (e.g. "CUDA" vs "GPU :: NVIDIA CUDA"), even when CUDA is available. GPU monitoring via pynvml is already optional and gracefully degrades when unavailable. The rest of the extension (metadata, pipes, debugger nodes, etc.) has no GPU dependency at all. Fixes crystian#271 Co-authored-by: Cursor <cursoragent@cursor.com>
|
i deleted row 10 and still shows as an issue/conflict |
|
So what is the fix? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Environment :: GPU :: NVIDIA CUDAclassifier frompyproject.tomlwhich causes ComfyUI's node pack validation to block loading the extensionCUDA) and the classifier string (GPU :: NVIDIA CUDA) prevents the extension from loading even on systems with NVIDIA GPUsFixes #271
Test plan