Refactor file lock#17105
Open
ysbaddaden wants to merge 1 commit into
Open
Conversation
The first attempt is always non-blocking, then further attempts will be blocking with execution contexts or non-blocking with regular polling for the legacy runtimes (without_mt, preview_mt). On Windows, when the file handle has been opened with the OVERLAPPED flag, we use an overlapped operations when blocking, and otherwise fallback to the algorithm described above. Also simpligies the system interface: - #system_lock(blocking, exclusive) - #system_unlock
ysbaddaden
force-pushed
the
refactor/flock
branch
from
26ff321 to
a3d5867
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplifies the system interface:
#system_lock(blocking, exclusive)#system_unlockRefactors the algorithm to leverage
Fiber.syscallwhen available instead of polling.The first attempt is always non-blocking, then further attempts will be blocking with execution contexts or non-blocking with regular polling for the legacy runtimes (without_mt, preview_mt).
On Windows, when the file handle has been opened with the OVERLAPPED flag, we use an overlapped operations when blocking, and otherwise fallback to the algorithm described above.