Skip to content

feat(platform): Add live USK catalog publishing#1334

Merged
leumor merged 7 commits into
developfrom
feature/live-usk-catalog-publication
May 24, 2026
Merged

feat(platform): Add live USK catalog publishing#1334
leumor merged 7 commits into
developfrom
feature/live-usk-catalog-publication

Conversation

@leumor
Copy link
Copy Markdown
Collaborator

@leumor leumor commented May 23, 2026

Summary

  • Add explicit crypta-app publish-usk --live support for signed first-party catalog publication to a live Crypta USK while preserving deterministic --dry-run publication plans.
  • Publish the catalog properties and sibling cryptad-app-catalog.signature through the localhost Platform API queue path with secure env/file secret inputs, public/private USK source correlation, no-proxy HTTP client behavior, retained staging sidecars, output preflight, and sanitized JSON/Markdown summaries.
  • Extend app-catalog/app-update scheduler coverage, release-certification evidence, docs, and redaction checks for PR-238 live catalog publication and refresh discovery.

Test Plan

  • ./gradlew spotlessApply
  • ./gradlew :platform-devtools:test --tests '*PlatformApiLiveUskPublisherTest' --tests '*LiveUskPublicationServiceTest'
  • ./gradlew :platform-devtools:test
  • python3 tools/release-certification/app_platform_smoke.py --self-test
  • python3 tools/release-certification/release_certification.py --self-test

Additional Verification

  • python3 tools/release-certification/app_platform_smoke.py --mode release-candidate --out-dir build/app-platform-smoke-review-fix was run to inspect the generated live catalog refresh evidence. The live refresh evidence passed and preserved boolean check values; the overall local release-candidate smoke failed because signing/reviewer inputs were not configured (app-platform.signed-bundles, catalog.smoke, and app-review.first-party-catalog).

Notes

  • Live-node insertion smoke was not run; no localhost Crypta node credentials or publication insert URI were configured for this environment.
  • Generated evidence was reviewed to keep private insert URIs, form passwords, tokens, raw bodies, and absolute staging paths out of release artifacts.

leumor added 4 commits May 23, 2026 21:26
Add live USK catalog publication for signed first-party catalogs, including localhost Platform API insertion, retained staging, public/private source correlation, sanitized summaries, release-certification evidence, docs, and focused tests.
Bypass inherited proxy selectors for the localhost live publication client and preflight summary output before staging or queueing live USK inserts.
Rename the live catalog refresh scheduler redaction check so sanitized release evidence preserves its boolean result, and assert self-test checks remain boolean.
Convert ValidatedPublicationInputs from a record to an immutable regular class with named builder construction and defensive sidecar byte copies.
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 97a727dde8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Clean staged catalog sidecars when live publication fails before queue acceptance, while retaining staging after queued inserts fail later verification.
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: dba63c5088

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Reject publish-usk output paths that would overwrite signed catalog sidecars, including existing filesystem aliases, and cover catalog/signature collision cases.
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 194c1d6a64

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Write a sanitized incomplete marker during live publication output preflight so failed attempts cannot leave prior success summaries readable.
@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
75.6% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@leumor leumor merged commit 545dd13 into develop May 24, 2026
18 of 19 checks passed
@leumor leumor deleted the feature/live-usk-catalog-publication branch May 24, 2026 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant