fix: My Valley row name overlapping chips on mobile (#459 follow-up)#460
Merged
Conversation
…low-up) On narrow (phone) widths, long favorite/visited names overlapped the news/events count chips and the Remove/Unmark button: the name's ellipsis never engaged because .my-valley-row-name was an inline span and its flex parent didn't constrain/clip it. - .my-valley-row-name: flex:1 + min-width:0 so it shrinks and truncates (ellipsis) in both the favorites row-open container and the visited row. - .my-valley-row-open: display:flex so the name truncates within it. - .my-valley-remove-btn: flex-shrink:0 so the button keeps its size. Verified at 360px: long names truncate, chips + buttons fully visible, no overflow. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the CSS layout for the MyValley component. It introduces flexbox properties (flex: 1, min-width: 0, and flex-shrink: 0) to ensure proper text truncation and alignment within the row elements, and aligns items vertically inside the clickable row container. There are no review comments, and we have no further feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On narrow (phone) widths, long favorite/visited names overlapped the news/events count chips and the Remove/Unmark button. The name's ellipsis truncation never engaged because
.my-valley-row-namewas an inline<span>and its flex parent didn't constrain/clip it.Fix (CSS only,
MyValley.css):.my-valley-row-name:flex:1+min-width:0→ shrinks and truncates with ellipsis in both the favoritesrow-opencontainer and the visited row..my-valley-row-open:display:flexso the name truncates within it..my-valley-remove-btn:flex-shrink:0so the button keeps its size.Follow-up to #459 (favorites list). Found via Chrome at simulated phone width.
Test plan
./run.sh buildpasses🤖 Generated with Claude Code