feat(tasks): add support for task batches (batchId) and the consolidated vendor task form - #386
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the Tasks API module in this .NET Standard client library to align with the Crowdin API changes around task batching (batchId) and the consolidated vendor task creation form, with accompanying unit tests and fixtures.
Changes:
- Add
batchIdsupport for List Tasks (query params) and Edit Task (patch path), plus create-form support inTaskCreateForm/EnterpriseTaskCreateForm. - Introduce
CrowdinVendorTaskCreateFormand add serialization + list filtering tests/fixtures. - Mark legacy vendor/language-service task create forms as
[Obsolete]to steer users toward updated API models.
Reviewed changes
Copilot reviewed 14 out of 15 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/Crowdin.Api.UnitTesting/Tests/Tasks/TasksApiTests.cs | Adds tests for consolidated vendor create form serialization, list filtering by batchId, and new patch paths. |
| tests/Crowdin.Api.UnitTesting/Resources/Tasks.resx | Adds JSON fixtures for the new vendor create form and a list-tasks response including batchId. |
| tests/Crowdin.Api.UnitTesting/Resources/Tasks.Designer.cs | Exposes newly added Tasks.resx fixtures via strongly-typed resource properties. |
| src/Crowdin.Api/Tasks/VendorOhtTaskCreateForm.cs | Marks legacy vendor form as obsolete (API migration guidance). |
| src/Crowdin.Api/Tasks/VendorManualTaskCreateForm.cs | Marks legacy vendor form as obsolete (API migration guidance). |
| src/Crowdin.Api/Tasks/VendorManualPendingTaskCreateForm.cs | Marks legacy vendor form as obsolete (API migration guidance). |
| src/Crowdin.Api/Tasks/VendorGengoTaskCreateForm.cs | Marks legacy vendor form as obsolete (API migration guidance). |
| src/Crowdin.Api/Tasks/LanguageServiceTaskCreateForm.cs | Marks legacy vendor-related form as obsolete (API migration guidance). |
| src/Crowdin.Api/Tasks/TasksListParams.cs | Adds BatchId and includes it in query param generation. |
| src/Crowdin.Api/Tasks/TasksApiExecutor.cs | Adds batchId optional parameter to ListTasks convenience overloads. |
| src/Crowdin.Api/Tasks/ITasksApiExecutor.cs | Adds batchId optional parameter to ListTasks interface overloads. |
| src/Crowdin.Api/Tasks/TaskPatch.cs | Fixes /labelIds path and adds /batchId + /resetScope patch paths. |
| src/Crowdin.Api/Tasks/TaskCreateForm.cs | Adds batchId to Crowdin (non-enterprise) task create form. |
| src/Crowdin.Api/Tasks/EnterpriseTaskCreateForm.cs | Adds batchId to Enterprise task create form. |
| src/Crowdin.Api/Tasks/CrowdinVendorTaskCreateForm.cs | Introduces the consolidated vendor task creation form model. |
Files not reviewed (1)
- tests/Crowdin.Api.UnitTesting/Resources/Tasks.Designer.cs: Generated file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+74
to
+78
| [JsonProperty("dateFrom")] | ||
| public DateTimeOffset? DateFrom { get; set; } | ||
|
|
||
| [JsonProperty("dateTo")] | ||
| public DateTimeOffset? DateTo { get; set; } |
Comment on lines
+18
to
+21
| TaskStatus? status = null, | ||
| long? assigneeId = null, | ||
| IEnumerable<SortingRule>? orderBy = null); | ||
| IEnumerable<SortingRule>? orderBy = null, | ||
| long? batchId = null); |
andrii-bodnar
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #375