Skip to content

feat(bundles): add request body and export settings to Export Bundle - #382

Merged
andrii-bodnar merged 2 commits into
mainfrom
feature/issue-379_bundles-add-request-body
Jul 30, 2026
Merged

feat(bundles): add request body and export settings to Export Bundle#382
andrii-bodnar merged 2 commits into
mainfrom
feature/issue-379_bundles-add-request-body

Conversation

@innomaxx

Copy link
Copy Markdown
Collaborator

Closes #379

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Bundles API module to support the updated Export Bundle endpoint behavior (issue #379): sending an optional request body on export and exposing the echoed export settings on the export status response model.

Changes:

  • Extended ExportBundle(...) to accept an optional request body (ExportBundleRequest) for both Crowdin and Enterprise variants.
  • Added export settings fields to BundleExportAttributes to reflect the server’s echoed settings in responses.
  • Updated unit tests and .resx fixtures to cover request serialization and new response attributes (Crowdin + Enterprise).

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tests/Crowdin.Api.UnitTesting/Tests/Bundles/BundlesApiTests.cs Adds tests for export requests (Crowdin/Enterprise) and asserts new export attributes.
tests/Crowdin.Api.UnitTesting/Resources/Bundles.resx Updates/extends JSON fixtures for bundle export responses and request bodies.
tests/Crowdin.Api.UnitTesting/Resources/Bundles.Designer.cs Regenerates strongly-typed resource accessors for the new fixtures.
src/Crowdin.Api/Bundles/IBundlesApiExecutor.cs Updates the executor contract to accept an optional export request body.
src/Crowdin.Api/Bundles/ExportBundleRequest.cs Introduces request-body DTOs for Crowdin and Enterprise export options.
src/Crowdin.Api/Bundles/BundlesApiExecutor.cs Sends the optional request body on Export Bundle POST.
src/Crowdin.Api/Bundles/BundleExportAttributes.cs Adds response attributes for export settings echoed by the API.
Files not reviewed (1)
  • tests/Crowdin.Api.UnitTesting/Resources/Bundles.Designer.cs: Generated file
Comments suppressed due to low confidence (2)

tests/Crowdin.Api.UnitTesting/Tests/Bundles/BundlesApiTests.cs:414

  • ExportApprovedOnly is declared as bool? on BundleExportAttributes, but this assertion passes it directly to Assert.True(...) (expects bool) which will not compile. Assert it's not null and then check .Value.
            Assert.True(model!.Attributes.ExportApprovedOnly);

tests/Crowdin.Api.UnitTesting/Tests/Bundles/BundlesApiTests.cs:424

  • ExportStringsThatPassedWorkflow is nullable (bool?) on BundleExportAttributes, but the assertion passes it directly to Assert.True(...) which expects bool and will not compile. Assert it's not null and then check .Value.
            Assert.True(model.Attributes.ExportStringsThatPassedWorkflow);

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tests/Crowdin.Api.UnitTesting/Tests/Bundles/BundlesApiTests.cs
@andrii-bodnar
andrii-bodnar merged commit dcc11af into main Jul 30, 2026
3 checks passed
@andrii-bodnar
andrii-bodnar deleted the feature/issue-379_bundles-add-request-body branch July 30, 2026 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add request body and export settings to Export Bundle

3 participants