feat(bundles): add request body and export settings to Export Bundle - #382
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the Bundles API module to support the updated Export Bundle endpoint behavior (issue #379): sending an optional request body on export and exposing the echoed export settings on the export status response model.
Changes:
- Extended
ExportBundle(...)to accept an optional request body (ExportBundleRequest) for both Crowdin and Enterprise variants. - Added export settings fields to
BundleExportAttributesto reflect the server’s echoed settings in responses. - Updated unit tests and
.resxfixtures to cover request serialization and new response attributes (Crowdin + Enterprise).
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/Crowdin.Api.UnitTesting/Tests/Bundles/BundlesApiTests.cs | Adds tests for export requests (Crowdin/Enterprise) and asserts new export attributes. |
| tests/Crowdin.Api.UnitTesting/Resources/Bundles.resx | Updates/extends JSON fixtures for bundle export responses and request bodies. |
| tests/Crowdin.Api.UnitTesting/Resources/Bundles.Designer.cs | Regenerates strongly-typed resource accessors for the new fixtures. |
| src/Crowdin.Api/Bundles/IBundlesApiExecutor.cs | Updates the executor contract to accept an optional export request body. |
| src/Crowdin.Api/Bundles/ExportBundleRequest.cs | Introduces request-body DTOs for Crowdin and Enterprise export options. |
| src/Crowdin.Api/Bundles/BundlesApiExecutor.cs | Sends the optional request body on Export Bundle POST. |
| src/Crowdin.Api/Bundles/BundleExportAttributes.cs | Adds response attributes for export settings echoed by the API. |
Files not reviewed (1)
- tests/Crowdin.Api.UnitTesting/Resources/Bundles.Designer.cs: Generated file
Comments suppressed due to low confidence (2)
tests/Crowdin.Api.UnitTesting/Tests/Bundles/BundlesApiTests.cs:414
ExportApprovedOnlyis declared asbool?onBundleExportAttributes, but this assertion passes it directly toAssert.True(...)(expectsbool) which will not compile. Assert it's not null and then check.Value.
Assert.True(model!.Attributes.ExportApprovedOnly);
tests/Crowdin.Api.UnitTesting/Tests/Bundles/BundlesApiTests.cs:424
ExportStringsThatPassedWorkflowis nullable (bool?) onBundleExportAttributes, but the assertion passes it directly toAssert.True(...)which expectsbooland will not compile. Assert it's not null and then check.Value.
Assert.True(model.Attributes.ExportStringsThatPassedWorkflow);
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
andrii-bodnar
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #379