build: enable multi-platform image publishing again#36
Merged
Conversation
This used to work with the old build submodule and image.mk. With crossplane/build and imagelight.mk, we need to do the following: - use --platform $(IMAGE_PLATFORMS) for docker buildx to build for all platforms - copy all architectures of the compiled test binary to IMAGE_TEMP_DIR - copy specific compiled conformance test binary in Dockerfile Signed-off-by: Jared Watts <jbw976@gmail.com>
jbw976
commented
Sep 17, 2025
|
|
||
| COPY --from=0 /go/bin/go-junit-report /usr/local/bin/ | ||
| ADD conformance /usr/local/bin/ | ||
| COPY tests/${TARGETOS}_${TARGETARCH}/tests /usr/local/bin/conformance |
Member
Author
There was a problem hiding this comment.
this pattern comes from https://github.com/crossplane/crossplane/blob/release-1.16/cluster/images/crossplane/Dockerfile
negz
approved these changes
Sep 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
This used to work with the old build submodule and image.mk, but I noticed we're no longer pushing multi-platform images now to https://hub.docker.com/repository/docker/crossplane/conformance/tags. This became obvious when running conformance tests with
crossplane/conformance:masterand seeing:With crossplane/build and imagelight.mk, we need to do the following with this PR:
--platform $(IMAGE_PLATFORMS)for docker buildx to build for all platformsIMAGE_TEMP_DIRI have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
I have built/published the changes in this PR to
jbw976/conformance:v2.0.0-cf.1.rc.0.4.gafde435-dirty. With the following changes:REGISTRY_ORGS ?= docker.io/jbw976image: jbw976/conformance:v2.0.0-cf.1.rc.0.4.gafde435-dirtyRun conformance test with
sonobuoyand the published multi-platform image:Successful conformance run!