validate: Use crossplane:stable as the default image#148
Conversation
Now that the CLI version has diverged from the Crossplane core version, we can't assume there will always be a core Crossplane image with the CLI's version number. Use the `stable` tag, which gets updated with each release, as the default Crossplane image for `validate` so that we always point at the latest. Users can still select a different version using the `--crossplane-image` flag. Fixes crossplane#145 Signed-off-by: Adam Wolfe Gordon <awg@upbound.io>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe validate command now uses a fixed default Crossplane image from the CLI flag definition. The runtime fallback that constructed an image tag from the current version was removed. ChangesValidate command image defaulting
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 error)
✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| CacheDir string `default:"~/.crossplane/cache" help:"Absolute path to the cache directory for downloaded schemas." predictor:"directory"` | ||
| CleanCache bool `help:"Clean the cache directory before downloading package schemas."` | ||
| CrossplaneImage string `help:"Specify the Crossplane image for validating built-in schemas."` | ||
| CrossplaneImage string `default:"xpkg.crossplane.io/crossplane/crossplane:stable" help:"Specify the Crossplane image for validating built-in schemas."` |
There was a problem hiding this comment.
this looks reasonable since we've now diverged versions and it looks like it correctly points to the most current stable image:
❯ docker run --rm xpkg.crossplane.io/crossplane/crossplane:stable --version
v2.3.3
|
Successfully created backport PR for |
Description of your changes
Now that the CLI version has diverged from the Crossplane core version, we can't assume there will always be a core Crossplane image with the CLI's version number. Use the
stabletag, which gets updated with each release, as the default Crossplane image forvalidateso that we always point at the latest. Users can still select a different version using the--crossplane-imageflag.Fixes #145
I have:
./nix.sh flake checkto ensure this PR is ready for review.- [ ] Added or updated unit tests.- [ ] Linked a PR or a docs tracking issue to document this change.backport release-x.ylabels to auto-backport this PR.