Skip to content

fix: add retry to curl calls #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fernandezcuesta wants to merge 2 commits into
base: main
Choose a base branch
from
+16 −14
Open

fix: add retry to curl calls #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b0d3337
fix: add retry to curl calls
fernandezcuesta Jun 8, 2026
5ab7c2c
Merge branch 'main' into fix/add-curl-retries
fernandezcuesta Jul 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions makelib/common.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,6 +262,8 @@ version.isdirty:
# ====================================================================================
# Helpers

CURL := curl -fsSL --progress-bar --retry 5 --retry-all-errors

SED_CMD?=sed -i -e

COMMA := ,
Expand Down
2 changes: 1 addition & 1 deletion makelib/golang.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ help-special: go.help
$(GOLANGCILINT):
@$(INFO) installing golangci-lint-v$(GOLANGCILINT_VERSION) $(SAFEHOSTPLATFORM)
@mkdir -p $(TOOLS_HOST_DIR)/tmp-golangci-lint || $(FAIL)
@curl -fsSL https://github.com/golangci/golangci-lint/releases/download/v$(GOLANGCILINT_VERSION)/golangci-lint-$(GOLANGCILINT_VERSION)-$(SAFEHOSTPLATFORM).tar.gz | tar -xz --strip-components=1 -C $(TOOLS_HOST_DIR)/tmp-golangci-lint || $(FAIL)
@$(CURL) https://github.com/golangci/golangci-lint/releases/download/v$(GOLANGCILINT_VERSION)/golangci-lint-$(GOLANGCILINT_VERSION)-$(SAFEHOSTPLATFORM).tar.gz | tar -xz --strip-components=1 -C $(TOOLS_HOST_DIR)/tmp-golangci-lint || $(FAIL)
@mv $(TOOLS_HOST_DIR)/tmp-golangci-lint/golangci-lint $(GOLANGCILINT) || $(FAIL)
@rm -fr $(TOOLS_HOST_DIR)/tmp-golangci-lint
@$(OK) installing golangci-lint-v$(GOLANGCILINT_VERSION) $(SAFEHOSTPLATFORM)
Expand Down
4 changes: 2 additions & 2 deletions makelib/helm.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,10 +173,10 @@ ifdef MUSEUM_URL
@$(INFO) pushing helm charts $(1) to chart museum $(MUSEUM_URL)
ifneq ($(MUSEUM_USER)$(MUSEUM_PASS),"")
@$(INFO) curl -u $(MUSEUM_USER):$(MUSEUM_PASS) --data-binary '@$(HELM_OUTPUT_DIR)/$(1)-$(HELM_CHART_VERSION).tgz' $(MUSEUM_URL)/api/charts
@curl -u $(MUSEUM_USER):$(MUSEUM_PASS) --data-binary '@$(HELM_OUTPUT_DIR)/$(1)-$(HELM_CHART_VERSION).tgz' $(MUSEUM_URL)/api/charts
@$(CURL) -u $(MUSEUM_USER):$(MUSEUM_PASS) --data-binary '@$(HELM_OUTPUT_DIR)/$(1)-$(HELM_CHART_VERSION).tgz' $(MUSEUM_URL)/api/charts
else
@$(INFO) curl --data-binary '@$(HELM_OUTPUT_DIR)/$(1)-$(HELM_CHART_VERSION).tgz' $(MUSEUM_URL)/api/charts
@curl --data-binary '@$(HELM_OUTPUT_DIR)/$(1)-$(HELM_CHART_VERSION).tgz' $(MUSEUM_URL)/api/charts
@$(CURL) --data-binary '@$(HELM_OUTPUT_DIR)/$(1)-$(HELM_CHART_VERSION).tgz' $(MUSEUM_URL)/api/charts
endif
@$(OK) pushing helm charts to chart museum
endif
Expand Down
22 changes: 11 additions & 11 deletions makelib/k8s_tools.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ build.vars: k8s_tools.buildvars
$(ISTIO):
@$(INFO) installing istio $(ISTIO_VERSION)
@mkdir -p $(TOOLS_HOST_DIR)/tmp-istio || $(FAIL)
@curl --progress-bar -fsSL https://github.com/istio/istio/releases/download/$(ISTIO_VERSION)/istio-$(ISTIO_VERSION)-$(ISTIO_DOWNLOAD_TUPLE).tar.gz | tar -xz -C $(TOOLS_HOST_DIR)/tmp-istio || $(FAIL)
@$(CURL) https://github.com/istio/istio/releases/download/$(ISTIO_VERSION)/istio-$(ISTIO_VERSION)-$(ISTIO_DOWNLOAD_TUPLE).tar.gz | tar -xz -C $(TOOLS_HOST_DIR)/tmp-istio || $(FAIL)
@mv $(TOOLS_HOST_DIR)/tmp-istio/istio-$(ISTIO_VERSION)/bin/istioctl $(ISTIO) || $(FAIL)
@rm -fr $(TOOLS_HOST_DIR)/tmp-istio || $(FAIL)
@$(OK) $(ISTIO) installing istio $(ISTIO_VERSION)
Expand All @@ -109,7 +109,7 @@ $(KCL):
@$(INFO) installing kcl $(KCL_VERSION)
@mkdir -p $(TOOLS_HOST_DIR)/tmp-kcl || $(FAIL)
@mkdir -p $(TOOLS_HOST_DIR)
@curl -fsSL https://github.com/kcl-lang/cli/releases/download/$(KCL_VERSION)/kcl-$(KCL_VERSION)-$(SAFEHOSTPLATFORM).tar.gz | tar -xz -C $(TOOLS_HOST_DIR)/tmp-kcl || $(FAIL)
@$(CURL) https://github.com/kcl-lang/cli/releases/download/$(KCL_VERSION)/kcl-$(KCL_VERSION)-$(SAFEHOSTPLATFORM).tar.gz | tar -xz -C $(TOOLS_HOST_DIR)/tmp-kcl || $(FAIL)
@mv $(TOOLS_HOST_DIR)/tmp-kcl/kcl $(KCL) || $(FAIL)
@rm -fr $(TOOLS_HOST_DIR)/tmp-kcl || $(FAIL)
@chmod +x $(KCL)
Expand All @@ -119,38 +119,38 @@ $(KCL):
$(KIND):
@$(INFO) installing kind $(KIND_VERSION)
@mkdir -p $(TOOLS_HOST_DIR) || $(FAIL)
@curl -fsSLo $(KIND) https://github.com/kubernetes-sigs/kind/releases/download/$(KIND_VERSION)/kind-$(SAFEHOSTPLATFORM) || $(FAIL)
@$(CURL) -o $(KIND) https://github.com/kubernetes-sigs/kind/releases/download/$(KIND_VERSION)/kind-$(SAFEHOSTPLATFORM) || $(FAIL)
@chmod +x $(KIND)
@$(OK) installing kind $(KIND_VERSION)

# kubectl download and install
$(KUBECTL):
@$(INFO) installing kubectl $(KUBECTL_VERSION)
@curl -fsSLo $(KUBECTL) --create-dirs https://dl.k8s.io/release/$(KUBECTL_VERSION)/bin/$(HOSTOS)/$(SAFEHOSTARCH)/kubectl || $(FAIL)
@$(CURL) -o $(KUBECTL) --create-dirs https://dl.k8s.io/release/$(KUBECTL_VERSION)/bin/$(HOSTOS)/$(SAFEHOSTARCH)/kubectl || $(FAIL)
@chmod +x $(KUBECTL)
@$(OK) installing kubectl $(KUBECTL_VERSION)

# kustomize download and install
$(KUSTOMIZE):
@$(INFO) installing kustomize $(KUSTOMIZE_VERSION)
@mkdir -p $(TOOLS_HOST_DIR)/tmp-kustomize
@curl -fsSL https://github.com/kubernetes-sigs/kustomize/releases/download/kustomize/$(KUSTOMIZE_VERSION)/kustomize_$(KUSTOMIZE_VERSION)_$(SAFEHOST_PLATFORM).tar.gz | tar -xz -C $(TOOLS_HOST_DIR)/tmp-kustomize
@$(CURL) https://github.com/kubernetes-sigs/kustomize/releases/download/kustomize/$(KUSTOMIZE_VERSION)/kustomize_$(KUSTOMIZE_VERSION)_$(SAFEHOST_PLATFORM).tar.gz | tar -xz -C $(TOOLS_HOST_DIR)/tmp-kustomize
@mv $(TOOLS_HOST_DIR)/tmp-kustomize/kustomize $(KUSTOMIZE)
@rm -fr $(TOOLS_HOST_DIR)/tmp-kustomize
@$(OK) installing kustomize $(KUSTOMIZE_VERSION)

# Crossplane CLI download and install
$(CROSSPLANE_CLI):
@$(INFO) installing Crossplane CLI $(CROSSPLANE_CLI_VERSION)
@curl -fsSLo $(CROSSPLANE_CLI) --create-dirs https://releases.crossplane.io/$(CROSSPLANE_CLI_CHANNEL)/$(CROSSPLANE_CLI_VERSION)/bin/$(SAFEHOST_PLATFORM)/crank?source=build || $(FAIL)
@$(CURL) -o $(CROSSPLANE_CLI) --create-dirs https://releases.crossplane.io/$(CROSSPLANE_CLI_CHANNEL)/$(CROSSPLANE_CLI_VERSION)/bin/$(SAFEHOST_PLATFORM)/crank?source=build || $(FAIL)
@chmod +x $(CROSSPLANE_CLI)
@$(OK) installing Crossplane CLI $(CROSSPLANE_CLI_VERSION)

# helm download and install
$(HELM):
@$(INFO) installing helm $(HELM_VERSION)
@mkdir -p $(TOOLS_HOST_DIR)/tmp-helm
@curl -fsSL https://get.helm.sh/helm-$(HELM_VERSION)-$(SAFEHOSTPLATFORM).tar.gz | tar -xz -C $(TOOLS_HOST_DIR)/tmp-helm
@$(CURL) https://get.helm.sh/helm-$(HELM_VERSION)-$(SAFEHOSTPLATFORM).tar.gz | tar -xz -C $(TOOLS_HOST_DIR)/tmp-helm
@mv $(TOOLS_HOST_DIR)/tmp-helm/$(SAFEHOSTPLATFORM)/helm $(HELM)
@rm -fr $(TOOLS_HOST_DIR)/tmp-helm
@$(OK) installing helm $(HELM_VERSION)
Expand All @@ -159,15 +159,15 @@ $(HELM):
$(KUTTL):
@$(INFO) installing kuttl $(KUTTL_VERSION)
@mkdir -p $(TOOLS_HOST_DIR)
@curl -fsSLo $(KUTTL) --create-dirs https://github.com/kudobuilder/kuttl/releases/download/v$(KUTTL_VERSION)/kubectl-kuttl_$(KUTTL_VERSION)_$(HOST_PLATFORM) || $(FAIL)
@$(CURL) -o $(KUTTL) --create-dirs https://github.com/kudobuilder/kuttl/releases/download/v$(KUTTL_VERSION)/kubectl-kuttl_$(KUTTL_VERSION)_$(HOST_PLATFORM) || $(FAIL)
@chmod +x $(KUTTL)
@$(OK) installing kuttl $(KUTTL_VERSION)

# chainsaw download and install
$(CHAINSAW):
@$(INFO) installing chainsaw $(CHAINSAW_VERSION)
@mkdir -p $(TOOLS_HOST_DIR)
@curl -fsSLo $(CHAINSAW).tar.gz --create-dirs https://github.com/kyverno/chainsaw/releases/download/v$(CHAINSAW_VERSION)/chainsaw_$(SAFEHOST_PLATFORM).tar.gz || $(FAIL)
@$(CURL) -o $(CHAINSAW).tar.gz --create-dirs https://github.com/kyverno/chainsaw/releases/download/v$(CHAINSAW_VERSION)/chainsaw_$(SAFEHOST_PLATFORM).tar.gz || $(FAIL)
@tar -xvf $(CHAINSAW).tar.gz chainsaw
@mv chainsaw $(CHAINSAW)
@chmod +x $(CHAINSAW)
Expand All @@ -178,14 +178,14 @@ $(CHAINSAW):
$(UPTEST):
@$(INFO) installing uptest $(UPTEST_VERSION)
@mkdir -p $(TOOLS_HOST_DIR)
@curl -fsSLo $(UPTEST) https://github.com/crossplane/uptest/releases/download/$(UPTEST_VERSION)/uptest_$(SAFEHOSTPLATFORM) || $(FAIL)
@$(CURL) -o $(UPTEST) https://github.com/crossplane/uptest/releases/download/$(UPTEST_VERSION)/uptest_$(SAFEHOSTPLATFORM) || $(FAIL)
@chmod +x $(UPTEST)
@$(OK) installing uptest $(UPTEST_VERSION)

# yq download and install
$(YQ):
@$(INFO) installing yq $(YQ_VERSION)
@mkdir -p $(TOOLS_HOST_DIR) && \
curl -fsSLo $(YQ) https://github.com/mikefarah/yq/releases/download/$(YQ_VERSION)/yq_$(SAFEHOST_PLATFORM) && \
$(CURL) -o $(YQ) https://github.com/mikefarah/yq/releases/download/$(YQ_VERSION)/yq_$(SAFEHOST_PLATFORM) && \
chmod +x $(YQ) || $(FAIL)
@$(OK) installing yq $(YQ_VERSION)