bug: update crossplane CLI install script env var names#20
Merged
Conversation
The names of the channel/version env vars have been updated upstream in the https://github.com/crossplane/crossplane/blob/main/install.sh#L5-L6 script. This commit changes the names to match. Signed-off-by: Jared Watts <jbw976@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR just makes the same update that was done in upbound#1, to update the env var names used in this action to match what's used in the Crossplane CLI install script: https://github.com/crossplane/crossplane/blob/main/install.sh#L5-L6
This action is still in use in https://github.com/crossplane/conformance and needs updating to get crossplane/conformance#31 succeeding.
This was attempted with #19, but failing DCO checks prevented that from being merged.