Add support for node identities to token operations#119
Merged
Conversation
rsommer
force-pushed
the
feat/acl_support_node_identities
branch
2 times, most recently
from
June 26, 2026 12:54
9e26765 to
0dea0e0
Compare
Contributor
Author
|
Locally linting succeeds: |
mougams
requested changes
Jun 29, 2026
mougams
left a comment
Contributor
There was a problem hiding this comment.
Thank you for your patch - a comment though
rsommer
force-pushed
the
feat/acl_support_node_identities
branch
from
June 29, 2026 08:37
0dea0e0 to
bf6d5c5
Compare
Contributor
|
@rsommer could you rebase and push again ? All the tests are failing due to mypy. Tried unsuccessfully a failed jobs retrigger 😕 |
Contributor
rsommer
force-pushed
the
feat/acl_support_node_identities
branch
from
July 5, 2026 15:54
bf6d5c5 to
e037db1
Compare
Contributor
Author
Done, all checks have passed ;) |
mougams
approved these changes
Jul 6, 2026
mougams
requested changes
Jul 6, 2026
| import builtins | ||
|
|
||
|
|
||
| def parse_identities(node_identities: list[str] | None) -> dict[typing.Any, typing.Any]: |
Contributor
There was a problem hiding this comment.
Sorry, just saw it - could you replace the return type by
dict[str, list[dict[str, str]]]
to make it more accurate.
feat(acl): support node identities in create and update methods. Both methods gained support for specifying a list of node identities when creating or updating a token. The node identities have to be given in the form of `["node01:dc1", "node02:dc1]` etc.
rsommer
force-pushed
the
feat/acl_support_node_identities
branch
from
July 6, 2026 08:18
e037db1 to
2509062
Compare
mougams
approved these changes
Jul 6, 2026
Contributor
|
All merged - thx @rsommer |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(acl): support node identities in create and update methods.
Both methods gained support for specifying a list of node identities when creating or updating a token. The node identities have to be given in the form of
["node01:dc1", "node02:dc1]etc.