Skip to content

Add a list_all_columns function to store and handler#46

Open
rom1504 wants to merge 1 commit into
add_total_countfrom
add_list_columns
Open

Add a list_all_columns function to store and handler#46
rom1504 wants to merge 1 commit into
add_total_countfrom
add_list_columns

Conversation

@rom1504

@rom1504 rom1504 commented Nov 19, 2019

Copy link
Copy Markdown

What changes are proposed in this pull request?

Add a list_all_columns function to store and handler
it takes as argument a list of experiment id
it returns the metrics, tags, params and attributes names
present for these experiments

this is particularly useful in an UI proposing to choose
columns

How is this patch tested?

  • test in sql alchemy store
  • test in file store
  • test in handler

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

add list_all_columns in API

What component(s) does this PR affect?

  • UI
  • CLI
  • API
  • REST-API
  • Examples
  • Docs
  • Tracking
  • Projects
  • Artifacts
  • Models
  • Scoring
  • Serving
  • R
  • Java
  • Python

How should the PR be classified in the release notes? Choose one:

  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

it takes as argument a list of experiment id
it returns the metrics, tags, params and attributes names
present for these experiments

this is particularly useful in an UI proposing to choose
columns
@codecov-io

Copy link
Copy Markdown

Codecov Report

Merging #46 into add_total_count will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##           add_total_count      #46   +/-   ##
================================================
  Coverage            83.46%   83.46%           
================================================
  Files                   20       20           
  Lines                 1010     1010           
================================================
  Hits                   843      843           
  Misses                 167      167

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fb9443...82bb9d1. Read the comment docs.

path: "/mlflow/columns/list"
since { major: 2, minor: 0 },
}, {
method: "POST",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You shouldn't use the POST method for this endpoint, IMO it should only be a GET

Comment thread mlflow/store/tracking/sqlalchemy_store.py
@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.46%. Comparing base (6fb9443) to head (82bb9d1).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@               Coverage Diff                @@
##           add_total_count      #46   +/-   ##
================================================
  Coverage            83.46%   83.46%           
================================================
  Files                   20       20           
  Lines                 1010     1010           
================================================
  Hits                   843      843           
  Misses                 167      167           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants