Fix fork go-tests lint and TLS API failure#266
Open
manu-ns wants to merge 2 commits into
Open
Conversation
The public fork go-tests workflow started running again in #265 and exposed these lint failures: https://github.com/criteo-forks/consul/actions/runs/28659505209 The affected lint debt came from the public fork patch stack, notably: - #263 - #264 This keeps the change mechanical: gofmt alignment, promoted embedded-field selectors, and bool comparison simplifications only.
After fork go-tests started running again via the public fork workflow fix, this test exposed a latent upstream failure mode: #265 The same assertion failure reproduces on the upstream v1.22.3 tag, so this is not tied to a Criteo feature PR: https://github.com/hashicorp/consul/tree/v1.22.3 Accept OS-level server-close errors from the missing-client-certificate handshake in addition to the existing Go TLS alert strings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Details
Validation
env GOLANGCI_LINT_CACHE=/tmp/golangci-lint-cache GOPATH=/tmp/consul-gopath GOCACHE=/tmp/consul-go-cache GOMODCACHE=/tmp/consul-gopath/pkg/mod golangci-lint run ./agent/consul ./agent/structsenv PATH=/home/manu/git/consul-criteo/bin:$PATH GOPATH=/tmp/consul-gopath GOCACHE=/tmp/consul-go-cache GOMODCACHE=/tmp/consul-gopath/pkg/mod go test . -run '^TestAPI_ClientTLSOptions$' -count=10