Skip to content

Update project coordinates for Clojars#3

Open
dharrigan wants to merge 1 commit into
crinklywrappr:masterfrom
dharrigan:feat/clojars-verified-group-name
Open

Update project coordinates for Clojars#3
dharrigan wants to merge 1 commit into
crinklywrappr:masterfrom
dharrigan:feat/clojars-verified-group-name

Conversation

@dharrigan

Copy link
Copy Markdown
Contributor

Following their verified group names recommendation:

https://github.com/clojars/clojars-web/wiki/Verified-Group-Names

Bump up Clojure and test check to latest versions

-=david=-

Following their verified group names recommendation:

https://github.com/clojars/clojars-web/wiki/Verified-Group-Names

Bump up Clojure and test check to latest versions

-=david=-
@dharrigan

Copy link
Copy Markdown
Contributor Author

Hi @crinklywrappr!

Any thoughts on this PR? Would be nice to be able to have this library support verified group names (and thus make it more inline with clojure deps recommendations too).

Thank you.

-=david=-

@crinklywrappr

Copy link
Copy Markdown
Owner

Sorry for the delay. I forgot about this PR.

I will update test.check and push a new version to clojars soon. I'm less keen on changing the coordinates unless clojars forces me to do that. And there's no need to update the minimum supported Clojure version AFAIK.

@dharrigan

Copy link
Copy Markdown
Contributor Author

Hi,

Thank you for your feedback. Clojars has a policy of enforcing verified domain names for all new libraries, so I guess it would be fine to keep the current coordinates (although in deps.edn, one has to do gooff/gooff {:mvn/version ....} anyway)

Either way, I'm happy if you want to reject this PR :-) No problemo :-)

-=david=-

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants