Revert load runtime config by default and reintroduced runtime config flag#49
Merged
Merged
Conversation
This reverts commit 9645ccd.
wingyplus
changed the title
Owner
|
Thanks @wingyplus 🙇 I'll try to release a new version with this patch over the weekend. Given that it is a breaking change it'll most likely be 2.0. |
Owner
|
This has been released as v2.0.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the long-standing discussion in #39.
This PR reverts 9645ccd and reintroduces the
--runtime-configflag to the configuration at runtime when the flag is set.I would like to let you know that this is a breaking change, as the behaviour of how configuration is loaded has changed.