Skip to content

feat(account): finish C1 authority projection and query seams#641

Merged
skakri merged 1 commit into
mainfrom
feat/604-c1-finish
Jul 14, 2026
Merged

feat(account): finish C1 authority projection and query seams#641
skakri merged 1 commit into
mainfrom
feat/604-c1-finish

Conversation

@skakri

@skakri skakri commented Jul 13, 2026

Copy link
Copy Markdown
Member

Closes #604.

Completes the remaining C1 spine from the frozen phase-C v5 design:

  • finishes the stratified account fold, control-side stream ownership/grant/revoke effects, contested recovery, and point-in-time authority facts
  • adds monotone auth_len readiness gating so parked authority cannot leak registers or state while recoverable dependency failures are recomputed
  • adds V064 authority projection and atomic backfill/rollback coverage
  • exposes typed roster, owner, stream, and combined grant/device queries; grant plus device boundary is read from one SQLite snapshot and fails closed as Open, Cut, or Closed
  • keeps raw grant/cut helpers private to the account module
  • adds defensive fold, migration, transaction, corruption, order-independence, laundering, state-replay, and two-connection WAL snapshot tests

Validation:

  • cargo +nightly fmt --check
  • cargo clippy --workspace --all-targets -- -D warnings
  • cargo nextest run --workspace (2634 passed)
  • three final adversarial reviews: no actionable blockers

@skakri skakri force-pushed the feat/604-c1-finish branch from 134d431 to 6dd8a1a Compare July 13, 2026 23:49
@github-actions

github-actions Bot commented Jul 13, 2026

Copy link
Copy Markdown

SCIP oracle — resolution report

Heuristic→compiler edge resolution per corpus. Δ compares resolved-after to the main baseline (only when the corpus profile + tool version match).

corpus tool edges resolved (heuristic → compiler) precision recall monikers Δ vs main
c-libuv scip-clang 12283 37.8% → 47.8% 89.3% 48.7% 679 +0.0pp
cpp-yaml scip-clang 9223 43.2% → 73.1% 82.8% 40.1% 1038 +0.0pp
py-django scip-python 12937 29.8% → 73.5% 93.7% 84.1% 3036 +0.0pp
py-rich scip-python 8383 27.6% → 92.3% 95.0% 81.3% 1098 +0.0pp
rust-time rust-analyzer 11040 37.5% → 58.7% 68.7% 83.6% 510 +0.0pp
ts-rxjs scip-typescript 7875 39.6% → 94.9% 87.3% 77.4% 626 +0.0pp

resolved = Exact/Syntactic + compiler upgrades + resolved-external, over edge candidates with a callee range. precision/recall are the oracle eval metrics.

@codecov

codecov Bot commented Jul 13, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 98.21189% with 40 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
crates/rag-rat-core/src/oplog/account/fold.rs 97.52% 23 Missing ⚠️
crates/rag-rat-core/src/oplog/account/storage.rs 98.31% 17 Missing ⚠️

📢 Thoughts on this report? Let us know!

@github-actions

github-actions Bot commented Jul 13, 2026

Copy link
Copy Markdown

🐰 Bencher Report

Branchfeat/604-c1-finish
Testbedubuntu-latest

⚠️ WARNING: No Threshold found!

Without a Threshold, no Alerts will ever be generated.

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds flag.

Click to view all benchmark results
BenchmarkEstimated Cyclescycles x 1e6Instructionsinstructions x 1e6L1 Hitshits x 1e6LL Hitshits x 1e6RAM Hitshits x 1e3Total read+writereads/writes x 1e6
rag_pipeline::pipeline::index cargo_resolver:resolver_config()📈 view plot
⚠️ NO THRESHOLD
2,346.40 x 1e6📈 view plot
⚠️ NO THRESHOLD
1,534.39 x 1e6📈 view plot
⚠️ NO THRESHOLD
2,088.94 x 1e6📈 view plot
⚠️ NO THRESHOLD
42.38 x 1e6📈 view plot
⚠️ NO THRESHOLD
1,301.26 x 1e3📈 view plot
⚠️ NO THRESHOLD
2,132.63 x 1e6
rag_pipeline::pipeline::query_cold cargo_resolver:resolver_built_config()📈 view plot
⚠️ NO THRESHOLD
350.30 x 1e6📈 view plot
⚠️ NO THRESHOLD
232.84 x 1e6📈 view plot
⚠️ NO THRESHOLD
334.50 x 1e6📈 view plot
⚠️ NO THRESHOLD
2.99 x 1e6📈 view plot
⚠️ NO THRESHOLD
24.61 x 1e3📈 view plot
⚠️ NO THRESHOLD
337.51 x 1e6
rag_pipeline::pipeline::query_warm cargo_resolver:resolver_index()📈 view plot
⚠️ NO THRESHOLD
336.29 x 1e6📈 view plot
⚠️ NO THRESHOLD
223.71 x 1e6📈 view plot
⚠️ NO THRESHOLD
321.42 x 1e6📈 view plot
⚠️ NO THRESHOLD
2.80 x 1e6📈 view plot
⚠️ NO THRESHOLD
25.40 x 1e3📈 view plot
⚠️ NO THRESHOLD
324.24 x 1e6
🐰 View full continuous benchmarking report in Bencher

@github-actions

github-actions Bot commented Jul 13, 2026

Copy link
Copy Markdown

🐰 Bencher Report

Branchfeat/604-c1-finish
Testbedubuntu-latest
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
seconds (s)
(Result Δ%)
Upper Boundary
seconds (s)
(Limit %)
index_time/full_rebuild_cargo📈 view plot
🚷 view threshold
5.11 s
(-11.62%)Baseline: 5.78 s
7.65 s
(66.79%)
🐰 View full continuous benchmarking report in Bencher

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 134d431159

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread crates/rag-rat-core/src/oplog/account/storage.rs
Comment thread crates/rag-rat-core/src/oplog/account/fold.rs
@skakri skakri force-pushed the feat/604-c1-finish branch from 6dd8a1a to 67d75d8 Compare July 14, 2026 09:36
@skakri skakri force-pushed the feat/604-c1-finish branch from 67d75d8 to 1a3a69c Compare July 14, 2026 09:54
@skakri skakri merged commit 64ddaee into main Jul 14, 2026
25 checks passed
@skakri skakri deleted the feat/604-c1-finish branch July 14, 2026 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

phase C — C1: account control log + stratified fold (spine) (#405)

1 participant