Skip to content

Кутузова Анна Александровна Фт-320010 #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kutuzova-ann wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Кутузова Анна Александровна Фт-320010 #43

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3da0d66
Add files via upload
kutuzova-ann Apr 25, 2025
31135b4
Add files via upload
kutuzova-ann Apr 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions srctwo-sum.cpp
View file
Open in desktop

@czertyaka czertyaka May 19, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Файл назван srctwo-sum.cpp, а не two-sum.cpp. И находится в корневой директории проекта, а не в src/. Из-за этого не собираются тесты

Как поправить:

$ git mv srctwo-sum.cpp src/two-sum.cpp
$ git commit -m "moved file"
$ git push

Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
#include "two-sum.hpp"

bool two_sum(
const int nums[ARRAY_SIZE],
const int target,
std::size_t& index0,
std::size_t& index1
)

@czertyaka czertyaka May 19, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

С самим кодом все хорошо, но надо соблюдать последовательность в стиле)

Между сигнатурой функции и телом обычно не ставят новую строку, пробелы в for между выражениями где-то поставлены, а где-то нет

Для домашнего задания в университете совсем не критично, но в реальных проектах обычно за этим следят


{
for(int i = 0; i < ARRAY_SIZE - 1;i++)
{
for(int j = i+1; j < ARRAY_SIZE; j++)
{
if(nums[i] + nums[j] == target)
{
index0 = i;
index1 = j;
return true;
}
}
}
return false;
};
Loading