Трясцин Савелий Валерьевич#3
Closed
boboboba wants to merge 1 commit into
Closed
Conversation
czertyaka
requested changes
Nov 5, 2025
| { | ||
| if (text == nullptr || secret == nullptr) | ||
| return; | ||
| int secretLength = strlen(secret); |
Collaborator
There was a problem hiding this comment.
Длину text тоже можно заранее проверить
| { | ||
| if (text[j] == '\0') | ||
| { | ||
| needEnd = true; |
Collaborator
There was a problem hiding this comment.
Если заранее проверить длину text, то в needEnd не будет нужды
| { | ||
| break; | ||
| } | ||
| text[i] = '\x01'; |
Collaborator
There was a problem hiding this comment.
Вам, пожалуй, стоит перед работой функции посмотреть, нет ли в ней \x01. И если есть, прекращать работу.
Collaborator
There was a problem hiding this comment.
Можно так же попробовать организовать поиск неиспользуемого символа вместо \x01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.