Фролов Кирилл Владимирович#3
Open
MrPlesk2 wants to merge 2 commits into
Open
Conversation
czertyaka
requested changes
Oct 11, 2025
| int main() { | ||
| std::random_device rd; | ||
| std::mt19937 gen(rd()); | ||
| std::uniform_int_distribution<int> dist(1, 9); |
Collaborator
There was a problem hiding this comment.
А вот тут не совсем верно по 2 пунктам:
- Загадывать можно с 0, а число у вас генерируется в интервале [1, 9], а не [0, 9]
- Тип лучше выбрать беззнаковый
| std::mt19937 gen(rd()); | ||
| std::uniform_int_distribution<int> dist(1, 9); | ||
|
|
||
| int random_num = dist(gen); |
Collaborator
There was a problem hiding this comment.
Этот объект лучше сделать константой
|
|
||
| int random_num = dist(gen); | ||
|
|
||
| std::cout << "Guess a number from 0 to 9: " << std::endl; |
Collaborator
There was a problem hiding this comment.
Согласно ТЗ, это приглашение должно печататься перед каждой попыткой пользователя угадать, а не 1 раз
| int random_num = dist(gen); | ||
|
|
||
| std::cout << "Guess a number from 0 to 9: " << std::endl; | ||
| int guessed_num; |
Collaborator
There was a problem hiding this comment.
Лучше все-таки не оставлять неинициализированные переменные. В данном случае нек будет ни UB, ни ошибок, но с точки зрения поддержки и дальнейшего развития кода будет лучше всегда чем-то инициализировать
czertyaka
approved these changes
Oct 22, 2025
czertyaka
left a comment
czertyaka
left a comment
Collaborator
There was a problem hiding this comment.
Принято, PR вливать не нужно.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.