-
Notifications
You must be signed in to change notification settings - Fork 1
Пестов Владимир Алексеевич #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
BasedDepartment1
wants to merge
1
commit into
cppdevcourse:master
Choose a base branch
from
BasedDepartment1:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -50,6 +50,8 @@ std::uint16_t Flags::GetBits(const Flags::Bits bits) const | |
| result[3] = bitset[0]; | ||
| return result.to_ulong(); | ||
| } | ||
| default: | ||
| throw std::runtime_error("unknown flags"); | ||
| } | ||
| } | ||
|
|
||
|
|
@@ -151,10 +153,26 @@ void Query::ParseQuestion(const std::vector<std::byte>& bytes) | |
| throw std::runtime_error("insufficient DNS question length"); | ||
| } | ||
|
|
||
| // TODO: добавьте десериализацию секции question из массива | ||
| // байт bytes. В первых 12 элементах массива находится | ||
| // заголовок header, question находится сразу после него. | ||
| // В этом методе необходимо заполнить поле this->question. | ||
| std::string name{}; | ||
| auto data_ptr = bytes.data() + 12; | ||
|
|
||
| while (std::to_integer<size_t>(*data_ptr) != 0) | ||
| { | ||
| auto subsection_length = std::to_integer<size_t>(*data_ptr); | ||
| ++data_ptr; | ||
|
|
||
| name.append((const char*)(data_ptr), subsection_length); | ||
| name += "."; | ||
|
|
||
| data_ptr += subsection_length; | ||
| } | ||
| ++data_ptr; | ||
| question.name = name; | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Можно было бы, пожалуй, обойтись без временного объекта |
||
|
|
||
| std::memcpy(&question.type, data_ptr, 2); | ||
| question.type = ntohs(question.type); | ||
| std::memcpy(&question.classCode, data_ptr + 2, 2); | ||
| question.classCode = ntohs(question.classCode); | ||
| } | ||
|
|
||
|
|
||
|
|
@@ -189,12 +207,36 @@ void Response::SerializeHeader(std::vector<std::byte>& bytes) const | |
| std::memcpy(&bytes[10], &numberOfAdditionalRRs, 2); | ||
| } | ||
|
|
||
| void Response::SerializeQuestion( | ||
| [[maybe_unused]] std::vector<std::byte>& bytes) const | ||
| void Response::SerializeQuestion(std::vector<std::byte>& bytes) const | ||
| { | ||
| // TODO: добавьте сериализацию поля this->question в массив | ||
| // байтов bytes. Bytes уже содержит сериализованный заголовок | ||
| // header, question необходимо добавить в конец массива. | ||
| bytes.resize(bytes.size() + question.name.size() + 1 + /*type*/ 2 + | ||
| /*classCode*/ 2); | ||
|
|
||
| uint8_t subsection_length = 0; | ||
| size_t subsection_start = 0; | ||
| auto data_ptr = bytes.data() + sizeof(header); | ||
| for (size_t i = 0; i < question.name.size(); ++i) | ||
| { | ||
| if (question.name[i] != '.') | ||
| { | ||
| ++subsection_length; | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Вот это можно было бы вычислить через какой-нибудь из методов строки |
||
| continue; | ||
| } | ||
|
|
||
| *data_ptr++ = static_cast<std::byte>(subsection_length); | ||
| std::memcpy(data_ptr, question.name.data() + subsection_start, | ||
| subsection_length); | ||
| data_ptr += subsection_length; | ||
|
|
||
| subsection_start = i + 1; | ||
| subsection_length = 0; | ||
| } | ||
| *data_ptr++ = std::byte{0}; | ||
|
|
||
| uint16_t type = htons(question.type); | ||
| uint16_t class_code = htons(question.classCode); | ||
| std::memcpy(data_ptr, &type, 2); | ||
| std::memcpy(data_ptr + 2, &class_code, 2); | ||
| } | ||
|
|
||
| } // namespace dns | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
C-style касты и
reinterpret_cast-ы очень часто ведут к нарушению правил strict aliasing. Правильно тут было бы сделать std::memcpy, компиляторы обычно это хорошо оптимизируют.