Replace bool and istruefalse with getboolean#4
Open
cormacmlynch wants to merge 2 commits into
Open
Conversation
The 'bool' method would not pick up when arguments in the ini file would be set to False. The istruefalse method works but is fragile (relies on user using 'True'). The getboolean method should be more robust.
There was a problem hiding this comment.
Pull request overview
This PR fixes boolean parsing from settings.ini by replacing incorrect bool(config.get(...)) and a fragile string comparison helper with ConfigParser.getboolean(), ensuring values like False are correctly interpreted as False.
Changes:
- Removed the
istruefalselambda that only treated the exact string"True"as true. - Replaced
bool(config.get(...))withconfig.getboolean(...)for multiple settings flags (SWITCH_WITHIN_YEAR_LOOP,mrio_inverse_recalculate,CALIBRATING,ftt_run,WRITE_AT_END). - Added a console print showing the parsed
ftt_runvalue.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 'bool' method would not pick up when arguments in the ini file would be set to False.
The istruefalse method works but is fragile (relies on user using 'True'). The getboolean method should be more robust.