Skip to content

modernising dynamite#12

Open
IainHammond wants to merge 19 commits into
cpinte:masterfrom
IainHammond:master
Open

modernising dynamite#12
IainHammond wants to merge 19 commits into
cpinte:masterfrom
IainHammond:master

Conversation

@IainHammond
Copy link
Copy Markdown

@IainHammond IainHammond commented May 7, 2026

  • setup.py was broken so I've created a pyproject.toml
  • removed requirements.txt
  • added .gitignore
  • added casa_cube and celerite2 as dependencies
  • removed alive_progress in favour of tqdm since most people will have that installed already
  • fixed all of the syntax errors related to print statements
  • upgrade celerite to celerite2

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request transitions the project to a modern PEP 517 build system using pyproject.toml, replaces alive-progress with tqdm, and migrates Gaussian Process functionality to celerite2. The reviewer identified several off-by-one errors in channel processing loops, a logic error where a kernel component was unintentionally overwritten, and an incorrect API call to celerite2 that would cause a runtime error. Additionally, feedback was provided to remove a premature Python 3.14 classifier and to use more idiomatic f-strings for plot titles.

Comment thread src/dynamite/measure_height.py Outdated
Comment thread src/dynamite/measure_height.py Outdated
Comment thread src/dynamite/measure_height.py Outdated
Comment thread src/dynamite/measure_height.py Outdated
Comment thread pyproject.toml
Comment thread src/dynamite/measure_height.py
Comment thread src/dynamite/measure_height.py
@IainHammond
Copy link
Copy Markdown
Author

IainHammond commented May 7, 2026

none of the remaining Gemini suggestions are needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant