refactor: use Perl 5.10 defined-or operator throughout (GH #308)#451
Draft
toddr-bot wants to merge 1 commit into
Draft
refactor: use Perl 5.10 defined-or operator throughout (GH #308)#451toddr-bot wants to merge 1 commit into
toddr-bot wants to merge 1 commit into
Conversation
Replace 'VAR = VAL unless defined VAR' with 'VAR //= VAL' and 'defined X ? X : Y' with 'X // Y' across 20 modules. Perl 5.10 has been the minimum since Makefile.PL already declares it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Replace legacy
defined-based patterns with Perl 5.10's//and//=operators across 20 modules.Why
Addresses GH #308. Perl 5.10 has been the minimum version since
Makefile.PLdeclaresMIN_PERL_VERSION => '5.010'anduse 5.010. The defined-or operator (//) was introduced in 5.10 and is the idiomatic way to handle these patterns.How
Two mechanical, semantics-preserving transformations applied across the codebase:
$VAR = VAL unless defined $VAR→$VAR //= VAL(26 instances)$DEBUGpackage variable defaults$WHILE_MAX,$PRETTY,$BINMODE,$DYNAMIC,$DOCUMENT,$STAT_TTL,$MAX_DIRS$patternin VMethods)defined $X ? $X : 'fallback'→$X // 'fallback'(5 instances)Patterns deliberately NOT converted:
unless defined $x and length $x)return/last unless defined)Testing
Full test suite passes (2905 tests). All transformations are semantics-preserving —
//=is exactly equivalent to= ... unless defined.Quality Report
Changes: 20 files changed, 32 insertions(+), 32 deletions(-)
Code scan: clean
Tests: passed (OK)
Branch hygiene: clean
Generated by Kōan