Ship Template::Plugin::List (fix #439)#441
Merged
Merged
Conversation
Template::Plugin::List was excluded from the distribution by an overly broad MANIFEST.SKIP pattern (^lib/Template/Plugin/List) added in 2002 when an experimental lib/Template/Plugin/List/ directory existed. The pattern matched both the directory and the eventual List.pm file, so the plugin has never shipped to CPAN even though t/plugin_list.t was included. Remove the obsolete pattern and regenerate MANIFEST. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
^lib/Template/Plugin/Listline fromMANIFEST.SKIPsolib/Template/Plugin/List.pmis now included in the distribution.MANIFESTviamake manifestto add the entry.Background
The skip pattern was added by Andy Wardley in commit
c7dfeda1b(2002-03-12) one minute before he committedList.pmitself inbd08966fwith the message "added Math and List plugins (not in main distribution yet)". The pattern was meant for an experimentallib/Template/Plugin/List/directory but — being unanchored — also matchedList.pm. As a result the plugin has never shipped to CPAN in ~24 years, even thought/plugin_list.twas already inMANIFESTand references it.Reported in #439 by @veryrusty: installing 3.105 from CPAN fails because the test exists but the module does not.
Test plan
make manifestregeneratesMANIFESTcleanly withlib/Template/Plugin/List.pmaddedmake testpasses locallymake disttarball containslib/Template/Plugin/List.pmCloses #439
🤖 Generated with Claude Code