feat(types): improve paginate type inference and safety#59
Open
tris203 wants to merge 1 commit into
Open
Conversation
Refactor the paginate method in Automate and Manage to use generic types, preserving the argument and return types of the API method passed in. Update PaginationApiMethod and related helpers for better type inference. Add a type test to ensure correct usage and argument validation. Adjust test tsconfig rootDir for proper type checking.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Why
Previously, paginate erased method-specific types, returning Promise<unknown[]> and accepting loosely typed arguments. This made pagination harder to use safely and weakened editor/type-checking support.
This change keeps pagination behavior the same at runtime while making TypeScript catch invalid usage earlier.