Skip to content

[FIX] unblock Render build by relaxing Node engine constraint#110

Merged
Divide-By-0 merged 1 commit into
mainfrom
fix/missing-course-pages
May 16, 2026
Merged

[FIX] unblock Render build by relaxing Node engine constraint#110
Divide-By-0 merged 1 commit into
mainfrom
fix/missing-course-pages

Conversation

@advikasinha

@advikasinha advikasinha commented May 16, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Relaxes engines.node in package.json from 18.x to >=18 so Render (running Node 21.6.2) can complete yarn install and build successfully
  • Adds an early-exit guard in fillMissingBlocks so the loop stops immediately if getBlocks returns nothing (inaccessible blocks), instead of burning all 10 iterations on the same IDs

Why courses were missing

The block-fetching fixes (normalizeRecordMap + fillMissingBlocks) were already on main since April 15–22 but were never deployed — every Render build attempt since then failed at yarn install before any code ran. The live site has been serving a stale pre-fix build. This PR unblocks the build so those fixes actually reach production.

Test plan

  • Render build passes with Node 21
  • Homepage shows all courses (not just the first ~100 blocks worth)

TLDR;
Resolves issue where courses disappeared when Notion pages exceeded 100 blocks.
Unblock build errors by updating the package dependencies

@coursetexts-dev coursetexts-dev temporarily deployed to fix/missing-course-pages - preview.coursetexts.org PR #110 May 16, 2026 03:11 — with Render Destroyed
@coursetexts-dev coursetexts-dev temporarily deployed to fix/missing-course-pages - coursetexts.org PR #110 May 16, 2026 03:11 — with Render Destroyed
@advikasinha

Copy link
Copy Markdown
Collaborator Author

For the main site:

https://coursetexts-org-pr-110.onrender.com/ versus https://coursetexts.org/: has 2 extra courses that are being rendered now
Applied Econometrics: Politics, Sports, Microeconomics (ECON 438)
Topics in Prose Fiction : World Literature and the Art of Beginning (GER 303)
image

@advikasinha

Copy link
Copy Markdown
Collaborator Author

the preview website also has all the course pages now.

example:
image

@advikasinha advikasinha changed the title [FIX] handle Notion's double-nested recordMap format and refetch miss… [FIX] unblock Render build by relaxing Node engine constraint May 16, 2026
@Divide-By-0 Divide-By-0 merged commit 7630097 into main May 16, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants