[FIX] unblock Render build by relaxing Node engine constraint#110
Merged
Conversation
Collaborator
Author
|
For the main site: https://coursetexts-org-pr-110.onrender.com/ versus https://coursetexts.org/: has 2 extra courses that are being rendered now |
Collaborator
Author
64bitpandas
approved these changes
May 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
engines.nodeinpackage.jsonfrom18.xto>=18so Render (running Node 21.6.2) can completeyarn installand build successfullyfillMissingBlocksso the loop stops immediately ifgetBlocksreturns nothing (inaccessible blocks), instead of burning all 10 iterations on the same IDsWhy courses were missing
The block-fetching fixes (
normalizeRecordMap+fillMissingBlocks) were already onmainsince April 15–22 but were never deployed — every Render build attempt since then failed atyarn installbefore any code ran. The live site has been serving a stale pre-fix build. This PR unblocks the build so those fixes actually reach production.Test plan
TLDR;
Resolves issue where courses disappeared when Notion pages exceeded 100 blocks.
Unblock build errors by updating the package dependencies