Conversation
When def exceeds math.MaxInt64, sync_gateway's gocb-backed Incr casts it to int64 (which goes negative), and gocbcore interprets that as the "do not create if absent" sentinel — the server then returns KEY_ENOENT. Rosmar previously created the doc with the wrapped value instead. Detect the sentinel and return sgbucket.MissingError to match. TestIncr is now table-driven and covers the matrix verified against both backends: amt=0 (read-but-rewrite + CAS bump), uint64-wrap "negative" amt, missing vs existing key, and the new def-sentinel case in both states. Adds a small ptr[T] helper in utils.go used by the test seed values. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CBG-5411
When def exceeds
math.MaxInt64, sync_gateway's gocb-backedIncrcasts it to int64 (which goes negative), and gocbcore interprets that as the "do not create if absent" sentinel — the server then returns KEY_ENOENT. Rosmar previously created the doc with the wrapped value instead.Detect the sentinel and return sgbucket.MissingError to match.
TestIncr is now table-driven and covers the matrix verified against both backends: amt=0 (read-but-rewrite + CAS bump), uint64-wrap "negative" amt, missing vs existing key, and the new def-sentinel case in both states. Adds a small ptr[T] helper in utils.go used by the test seed values.