Conversation
bbrks
requested changes
Jan 5, 2026
| if err := msg.Close(); err != nil { | ||
| sender.context.logFrame("Warning: Sender encountered error closing messages in icebox. Error: %v", err) | ||
| } | ||
| delete(sender.icebox, key) |
Member
There was a problem hiding this comment.
I think this could result in a build up of goroutines or messages again that will never be cleared from the icebox (see the godoc comment referring to CBG-4572)
We're unintentionally still guarded today by the panic when things get put in the icebox after a close.
I think it would still be preferable to nil the icebox map but add a nil check to requeue to early exit to avoid putting more things in it? Both functions have their locks to avoid races between the two.
bbrks
approved these changes
Jan 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CBG-5031
Panic seems to happen when closing a sender's messages in icebox we seem to nil the icebox after. We should avoid this and just clear the messages in the icebox to avoid this panic.