Skip to content

Add 'aaa' package#39

Closed
cottsay-alt wants to merge 1 commit into
cottsay:rosdistro-reviewerfrom
cottsay-alt:add-aaa
Closed

Add 'aaa' package#39
cottsay-alt wants to merge 1 commit into
cottsay:rosdistro-reviewerfrom
cottsay-alt:add-aaa

Conversation

@cottsay-alt

Copy link
Copy Markdown

From a "first time contributor"

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Introduction
Thanks for sending a pull request to ROS distro!

This is an automated tool that helps check your pull request for correctness.
This tool checks a number of attributes associated with your ROS package and generates a report that helps our reviewers merge your pull request in a timely fashion. Here are a few things to consider when sending adding or updating a package to ROS Distro.
ROS Distro includes a very helpful CONTRIBUTING.md file that we recommend reading if it is your first time submitting a package.
Please also read the ROS Distro review guidelines which summarizes this release process.

ROS Distro Considerations

Package Considerations

Having your package included in a ROS Distro is a badge of quality, and we recommend that package developers strive to create packages of the highest quality. We recommend package developers review the following resources before submitting their package.

Need Help?

Please post your questions to Robotics Stack Exchange or refer to the Infrastructure General channel on our Zulip server.


For changes related to rosdep:

  • ❌ There are problems with the names of new rosdep keys:
    • Keys which contain only pip rules should end in '-pip'
  • ✅ New keys appear suitable for rosdep
  • 📝 Disclaimer: Pip-only rules cannot be used by packages on the ROS buildfarm

For changes related to yamllint:

  • ✅ All new lines of YAML pass linter checks

Comment thread rosdep/python.yaml
@@ -1,3 +1,7 @@
aaa:

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This key should end in '-pip'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants