Add a new pip rule#36
Closed
cottsay wants to merge 3 commits into
Closed
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
For changes related to rosdep:
- ✅ New rosdep keys are named appropriately
- ✅ New keys appear suitable for rosdep
- 📝 Disclaimer: Pip-only rules cannot be used by packages on the ROS buildfarm
For changes related to yamllint:
- ✅ All new lines of YAML pass linter checks
There was a problem hiding this comment.
For changes related to rosdep:
- ✅ New rosdep keys are named appropriately
- ✅ New keys appear suitable for rosdep
- 📝 Disclaimer: Pip-only rules cannot be used by packages on the ROS buildfarm
For changes related to yamllint:
- ❌ One or more linter violations were added to YAML files
| aaa-pip: | ||
| '*': | ||
| pip: | ||
| packages: [aaa] |
There was a problem hiding this comment.
This line does not pass YAML linter checks: trailing spaces
This reverts commit 8c0beab.
There was a problem hiding this comment.
For changes related to rosdep:
- ✅ New rosdep keys are named appropriately
- ✅ New keys appear suitable for rosdep
- 📝 Disclaimer: Pip-only rules cannot be used by packages on the ROS buildfarm
For changes related to yamllint:
- ✅ All new lines of YAML pass linter checks
github-actions
Bot
dismissed
their stale review
Previous automated review is stale
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.