Skip to content

Cosipy asi pipeline#605

Open
ldigesu wants to merge 29 commits into
cositools:developfrom
ldigesu:cosipy_asi_pipeline
Open

Cosipy asi pipeline#605
ldigesu wants to merge 29 commits into
cositools:developfrom
ldigesu:cosipy_asi_pipeline

Conversation

@ldigesu

@ldigesu ldigesu commented May 8, 2026

Copy link
Copy Markdown
Contributor

In this draft PR, I add the command-line app cosi-tsdetect to the available pipeline tasks. This automates the TS map fitting and extracts the coordinates at the maximum TS value.

To demonstrate the usage I added in docs/tutorials/apps the file run_pipeline_zero.sh, which used all the available apps for an end-to-end analysis pipeline of a point-like source with known tstart-tstop. This is what is currently being used by Francesco Fenu in the prototype of the comprehensive pipeline in cosiflow. I updated the documentation accordingly apps.rst accordingly with all the explanations. I also updated the unit test for the app. I think this PR is of interest for people working in the pipeline @NicoloParmiggiani @falric05 @ckierans

I still have the following minor problems @israelmcmc :
-for the tutorial pipeline_zero: the orientation file DC3_final_530km_3_month_with_slew_1sbins_GalacticEarth_SAA.fits has either changed name or location in wasabi, and currently the fetching command throws an error

-for the unit test: the apps are not working with the files already available in test_data. However, the test is passed anyway

Once these are solved, this can be converted to a normal PR. I am also open to feedback if things are better arranged in another way.

@codecov

codecov Bot commented May 20, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 59.33333% with 61 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.43%. Comparing base (88569f1) to head (2fb3e72).

Files with missing lines Patch % Lines
cosipy/pipeline/task/task.py 62.72% 41 Missing ⚠️
cosipy/pipeline/src/fitting.py 45.94% 20 Missing ⚠️
Files with missing lines Coverage Δ
cosipy/pipeline/src/preprocessing.py 100.00% <100.00%> (+100.00%) ⬆️
cosipy/pipeline/src/fitting.py 40.29% <45.94%> (+40.29%) ⬆️
cosipy/pipeline/task/task.py 55.65% <62.72%> (+55.65%) ⬆️

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ldigesu ldigesu marked this pull request as ready for review May 21, 2026 11:40
@jdbuhler

jdbuhler commented May 21, 2026

Copy link
Copy Markdown
Contributor

The orientation file you want is now in COSI-SMEX/DC4/Data/Orientation. The name was changed to start with DC4 instead of DC3 but is otherwise the same.

COSI-SMEX/DC4/Data/Orientation/DC4_final_530km_3_month_with_slew_1sbins_GalacticEarth_SAA.fits

@israelmcmc

Copy link
Copy Markdown
Collaborator

Thanks @jdbuhler. I think that solves the first of @ldigesu's points.

As for the other:

-for the unit test: the apps are not working with the files already available in test_data. However, the test is passed anyway

@ldigesu Can you please clarify what you meant? Is it that the result don't make sense but the unit test still pass? If so, maybe it's due to the test files being very poor --i.e. to coarse. It's enough to test the mechanics, so maybe that's fine for now if you understand what's going on under the hood of the test.

@israelmcmc israelmcmc added the pull-request-needs-reviewer No reviewer assigned label Jun 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pull-request-needs-reviewer No reviewer assigned

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants