Skip to content

Fix typos in settings key accesses#277

Open
cameronblandford wants to merge 1 commit into
cos-labs:developfrom
cameronblandford:fix/title-style
Open

Fix typos in settings key accesses#277
cameronblandford wants to merge 1 commit into
cos-labs:developfrom
cameronblandford:fix/title-style

Conversation

@cameronblandford

Copy link
Copy Markdown
Contributor

While the rest of collections has migrated to kebab case, for some reason these poor keys have been forgotten in the dust. This commit rescues them, giving them something warm to eat and apologizing for being so neglectful.

While the rest of collections has migrated to kebab case, for some reason these poor keys have been forgotten in the dust. This commit rescues them, giving them something warm to eat and apologizing for being so neglectful.
@NyanHelsing

Copy link
Copy Markdown
Contributor

does this still work? technically these are POJOs, and should have camelCase the reason they are now kebab I think is because we're preferring kebab in JSON. the fix here ought to be in the serializer to change all the kebab to camel and use camel in the spots changed above^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants