Fix typos in settings key accesses#277
Open
cameronblandford wants to merge 1 commit into
Open
Conversation
While the rest of collections has migrated to kebab case, for some reason these poor keys have been forgotten in the dust. This commit rescues them, giving them something warm to eat and apologizing for being so neglectful.
Contributor
|
does this still work? technically these are POJOs, and should have camelCase the reason they are now kebab I think is because we're preferring kebab in JSON. the fix here ought to be in the serializer to change all the kebab to camel and use camel in the spots changed above^ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While the rest of collections has migrated to kebab case, for some reason these poor keys have been forgotten in the dust. This commit rescues them, giving them something warm to eat and apologizing for being so neglectful.