Redis#69
Open
sloria wants to merge 20 commits into
Open
Conversation
Only supports inserting and querying On branch redis Changes to be committed: (use "git reset HEAD <file>..." to unstage) modified: dev-requirements.txt modified: modularodm/storage/__init__.py modified: modularodm/storage/mongostorage.py modified: modularodm/storage/picklestorage.py new file: modularodm/storage/redisstorage.py modified: tests/base.py new file: tests/storage/__init__.py new file: tests/storage/test_redisstorage.py
On branch redis Changes to be committed: (use "git reset HEAD^1 <file>..." to unstage) modified: modularodm/storage/picklestorage.py modified: modularodm/storage/redisstorage.py modified: tests/storage/test_redisstorage.py
Conflicts: modularodm/storage/base.py
On branch redis Your branch is up-to-date with 'origin/redis'. Changes to be committed: (use "git reset HEAD <file>..." to unstage) modified: modularodm/storage/redisstorage.py modified: tests/storage/test_redisstorage.py
On branch redis Your branch is ahead of 'origin/redis' by 1 commit. (use "git push" to publish your local commits) Changes to be committed: (use "git reset HEAD <file>..." to unstage) modified: modularodm/storage/redisstorage.py
the datatypes expected by an ODM query
…ular-odm into redis Conflicts: modularodm/storage/base.py
Wrongly assumed concrete implementations have a store attribute
Contributor
Author
|
Note: There are exactly 34 tests that are expected to fail. These have to do with how backends handle offsets and limits, which is TBD. |
Contributor
There was a problem hiding this comment.
Could some of these tests move into the backend-agnostic suites?
Contributor
Author
There was a problem hiding this comment.
Yeah. A lot of these tests are redundant; I'm sure similar ones were already written. I only wrote them for my own purposes to run while developing the Redis backend. But I'll move the non-redis-specific tests to the multiple-backend tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements RedisStorage