refactor(types): sync embedded types#28
Open
Bender B. Rodríguez (CortiDevOps) wants to merge 1 commit into
Open
refactor(types): sync embedded types#28Bender B. Rodríguez (CortiDevOps) wants to merge 1 commit into
Bender B. Rodríguez (CortiDevOps) wants to merge 1 commit into
Conversation
Bender B. Rodríguez (CortiDevOps)
force-pushed
the
sync/embedded-types
branch
from
9294e1c to
78f57f1
Compare
Bender B. Rodríguez (CortiDevOps)
force-pushed
the
sync/embedded-types
branch
from
78f57f1 to
86f2289
Compare
Morten Barklund (barklund)
changed the title
Morten Barklund (barklund)
requested review from
Copilot and
Zoltan Hricz (hriczzoli)
Comment on lines
+38
to
+39
| "src/corti-embedded.ts", | ||
| "src/corti-embedded.js", |
There was a problem hiding this comment.
This was just to remove a warning during test runs.
Comment on lines
+122
to
+123
| source: "standard", | ||
| id: "corti-soap", |
Comment on lines
281
to
294
| const navPayload = JSON.parse(navTextarea.value); | ||
| if (navPayload && typeof navPayload === 'string') { | ||
| if (navPayload && typeof navPayload === "string") { | ||
| navPayload.path = navPayload.path.replace( | ||
| '{interaction_id}', | ||
| "{interaction_id}", | ||
| String(interactionId), | ||
| ); | ||
| navTextarea.value = JSON.stringify(navPayload, null, 2); | ||
| } else { | ||
| // Fallback to string replace if unexpected structure | ||
| navTextarea.value = String(navTextarea.value).replace( | ||
| '{interaction_id}', | ||
| "{interaction_id}", | ||
| String(interactionId), | ||
| ); | ||
| } |
Bender B. Rodríguez (CortiDevOps)
changed the title
Bender B. Rodríguez (CortiDevOps)
force-pushed
the
sync/embedded-types
branch
from
2267f10 to
efc872d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync
packages/embedded-types/srcfrom assistant intosrc/types.