Bug fix: Run GitHub-triggered builds asynchronously so pull feedback isn't blocked by the build#67
Draft
jmsunseri wants to merge 2 commits into
Draft
Bug fix: Run GitHub-triggered builds asynchronously so pull feedback isn't blocked by the build#67jmsunseri wants to merge 2 commits into
jmsunseri wants to merge 2 commits into
Conversation
Running run_compile synchronously blocked the Celery task until the build finished, delaying the pull_complete UI feedback. Dispatching via .delay returns immediately so the frontend can respond to the pull before the build reports progress independently.
jmsunseri
force-pushed
the
github-performance
branch
from
a68a20e to
c446628
Compare
Catch GithubException on hook creation to prevent a 500 error when the user lacks write access. Roll back the hook UUID and update the UI message to clarify that write access is required.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix GitHub pull success feedback to appear when pull completes, not when build finishes
Fixes the pull UX so the green "Pulled successfully" alert and disabled controls are released as soon as the GitHub pull finishes. Previously the Celery task blocked on the optional auto-build, so the frontend didn't get a response until the build completed too.