drivers/speaker: Fix SF32LB speaker volume being reset during playback start#1554
Open
ShinkoNet wants to merge 1 commit into
Open
drivers/speaker: Fix SF32LB speaker volume being reset during playback start#1554ShinkoNet wants to merge 1 commit into
ShinkoNet wants to merge 1 commit into
Conversation
ShinkoNet
force-pushed
the
obelix-speakerfix
branch
from
ae481da to
007b9cf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
so, on my Pebble Time 2, an app using the speaker playback functions on the SDK could bypass the OS speaker mute/volume setting... I noticed the 2 Duo's DA7212 driver received a patch recently (7289a22), but the Time 2 did not.
The speaker service already passes the effective OS volume into the audio driver, but SF32LB AUDCODEC start path later reconfigures the DAC path, which resets the DAC mute/volume state. This caused playback to become audible and played at full volume even when the OS speaker volume was at 0 and the speaker was in a muted state, at least OS preference-wise.
This PR caches the requested volume in the SF32LB audio state and reapplies it after DAC path setup in audec_start.
I ran this build on my PT2 with PebbleOS v4.15.0 release as the base to confirm it fixed the issue.