Draw action bar on left or right depending on screen orientation#1502
Open
deadbaed wants to merge 6 commits into
Open
Draw action bar on left or right depending on screen orientation#1502deadbaed wants to merge 6 commits into
deadbaed wants to merge 6 commits into
Conversation
Draw action bar correctly when in left-handed mode, to have physical buttons aligned matching icons on the display. Signed-off-by: Philippe Loctaux <p@philippeloctaux.com>
Make QEMU boards able to be in left-handed mode Signed-off-by: Philippe Loctaux <p@philippeloctaux.com>
When building QEMU targets with `CONFIG_ORIENTATION_MANAGER`, the linking was failing on `accel_set_rotated` and `mag_set_rotated`. Implement stub drivers for QEMU targets. Signed-off-by: Philippe Loctaux <p@philippeloctaux.com>
Signed-off-by: Philippe Loctaux <p@philippeloctaux.com>
Member
|
UX should not be impacted (from the screenshots, there seems to be some fixes left to be implemented) |
Member
|
we also gotta consider how this is exposed to users (i.e. it should NOT affect legacy apps etc) |
Author
|
Took the time to investigate and fix the music app and the factory reset screen: 
Absolutely, I am a bit afraid third party apps might be in the same boat as the music app and the factory reset one. I do not know how to load third party apps on the simulator yet (I'll see how to do that), but I am planning to try out "popular" apps on the pebble app store to see how they would react. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1464 and #898, there is also a forum post discussing this issue.
AI
I used AI when doing research and during development, I used the
Big Picklemodel from OpenCode. The model wrote most of the code, the code looks good enough for me, but I'll let the maintainers judge it. Please let me know if it is wrong.QEMU targets and drivers
I tested only on QEMU targets (mainly on
qemu_emerysince I own a Pebble Time 2). I also made sure it compiles and looks okay onqemu_flintandqemu_gabbro.To get left handed mode working on QEMU platforms, I had to add
CONFIG_ORIENTATION_MANAGERto the Kconfig files.Since those boards did not have drivers for the accelerometer and magnetometer (by judging the linking errors and what the AI model told me), I added stub drivers for the QEMU targets.
Development tools
I used the nix dev shell:
Visual results
The UI looks good for the most part when I looked at applications and inside the settings.
There are 2 exceptions, the
Factory resetprompt and theMusicapp:I did not take the time to investigate why. I am opening this PR to get the discussion going and to gather feedback.
Please let me know if I did something wrong or forgot to do.