fw/applib/ui: extract day_picker as reusable component from alarm_editor#1474
Open
jmsunseri wants to merge 2 commits into
Open
fw/applib/ui: extract day_picker as reusable component from alarm_editor#1474jmsunseri wants to merge 2 commits into
jmsunseri wants to merge 2 commits into
Conversation
Author
|
cc @ericmigi |
Member
|
I wasn't aware we also do AI models |
Author
|
Lol I didn't tell it to do that.
Sincerely,
Justin Sunseri
…On Wed, Jun 10, 2026, 10:26 PM Gerard Marull-Paretas < ***@***.***> wrote:
*gmarull* left a comment (coredevices/PebbleOS#1474)
<#1474 (comment)>
I wasn't aware we also do AI models Co-authored-by: glm-5.1 <
***@***.***>
—
Reply to this email directly, view it on GitHub
<#1474?email_source=notifications&email_token=AAGEPFYA4WJMCUNM2T7JBSD47FV2TA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINRXGEZDQNJVGA4KM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#issuecomment-4671285508>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGEPF3EUNPKD5ZCSASJXI347FV2TAVCNFSNUABFKJSXA33TNF2G64TZHM4TQNRYGY3TEOJSHNEXG43VMU5TINRTGAZTKNRQGQYKC5QC>
.
Triage notifications, keep track of coding agent tasks and review pull
requests on the go with GitHub Mobile for iOS
<https://github.com/notifications/mobile/ios/AAGEPFY7VT2SLSZJKM55TY347FV2TA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINRXGEZDQNJVGA4KM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KUZTPN52GK4S7NFXXG>
and Android
<https://github.com/notifications/mobile/android/AAGEPF4R7XMJ6KX66ZJ7NZL47FV2TA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINRXGEZDQNJVGA4KM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2K4ZTPN52GK4S7MFXGI4TPNFSA>.
Download it today!
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
jmsunseri
force-pushed
the
day-picker-refactor
branch
from
1a95807 to
1f06f95
Compare
Author
this has been resolved |
jplexer
approved these changes
Jun 11, 2026
Author
|
@gmarull any update on this? |
Member
pls make sure CI is green first |
Extract the day picker and custom day picker UI into a standalone
reusable component in applib/ui/day_picker.{c,h}, replacing the
inline implementation that was embedded in alarm_editor.c.
The new DayPicker API provides:
- DayPickerConfig/DayPickerResult types for configuration and results
- DayPickerKind enum (Everyday, Weekdays, Weekends, Custom, JustOnce)
- day_picker_push() for the kind-selection screen
- custom_day_picker_push() for the day-of-week toggle screen
- day_picker_kind_get_string() for localized string lookup
alarm_editor.c now uses the new component via callback-based API,
replacing ~300 lines of inline UI code with thin conversion functions.
Co-authored-by: glm-5.1
Signed-off-by: Justin Sunseri <jmsunseri@gmail.com>
jmsunseri
force-pushed
the
day-picker-refactor
branch
from
1f06f95 to
1b9739d
Compare
day_picker.c uses resource IDs (CHECKBOX_ICON_CHECKED, CHECKBOX_ICON_UNCHECKED, CHECKMARK_ICON_BLACK, CHECKMARK_ICON_DOTTED) that are only available in the normal resource map, not in PRF. The alarms app that uses day_picker is already excluded from PRF, so exclude the component as well. Co-authored-by: glm-5.1 Signed-off-by: Justin Sunseri <jmsunseri@gmail.com>
Author
Sorry about that I didn't know they were failing because I can't run any of the tests because my PR originates from a fork. This should be resolved now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract the day picker and custom day picker UI into a standalone reusable component in applib/ui/day_picker.{c,h}, replacing the inline implementation that was embedded in alarm_editor.c.
The new DayPicker API provides:
alarm_editor.c now uses the new component via callback-based API, replacing ~300 lines of inline UI code with thin conversion functions.
This is a requirement for #1436 to try and break that work up into more manageable chunks. First we extract the day picker from the alarms scheduling tool. Then we can use it when improving quiet time scheduling.