fix: prevent authenticated GraphQL responses from being cached by CDNs#4867
Open
sashor wants to merge 1 commit into
Open
fix: prevent authenticated GraphQL responses from being cached by CDNs#4867sashor wants to merge 1 commit into
sashor wants to merge 1 commit into
Conversation
Adds CacheControlApolloServerPlugin that sets: - Vary: Authorization on all GraphQL responses - Cache-Control: private, no-store on authenticated responses This prevents CDNs and reverse proxies from serving one user's cached data to another user. Fixes coralproject#4856
✅ Deploy Preview for gallant-galileo-14878c canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #4856
When Coral is deployed behind a CDN or reverse proxy with shared caching enabled,
authenticated GraphQL responses may be served across users (e.g.
viewerReactionPresencefrom one user served to another).
This PR adds a new Apollo Server plugin (
CacheControlApolloServerPlugin) that:Vary: Authorizationon all GraphQL responses so caches key responsesseparately for authenticated vs unauthenticated requests
Cache-Control: private, no-storeon authenticated responses so sharedcaches never store user-specific data
These changes will impact:
What changes to the GraphQL/Database Schema does this PR introduce?
None.
Does this PR introduce any new environment variables or feature flags?
No.
If any indexes were added, were they added to
INDEXES.md?No indexes were added.
How do I test this PR?
graphqlCache-Control: private, no-storeandVary: Authorizationare presentVary: AuthorizationWere any tests migrated to React Testing Library?
No.
How do we deploy this PR?
No special deployment steps required.