Add a webhook and settings when comments get reported above a certain threshold #4865
Open
helderdb wants to merge 4 commits into
Open
Add a webhook and settings when comments get reported above a certain threshold #4865helderdb wants to merge 4 commits into
helderdb wants to merge 4 commits into
Conversation
✅ Deploy Preview for gallant-galileo-14878c canceled.
|
Author
|
@kabeaty Do I need to do anything else in order to get this merged? |
Contributor
|
Hi there, interesting feature, I have a few notes:
|
Author
|
Thank you for the reply @tessalt !
|
ce038fd to
670df7a
Compare
Author
|
@tessalt Updated the translations & moved the setting for the threshold to the webhook itself. The input field appears when you select the |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a new webhook event
COMMENT_REPORTED_THRESHOLD_REACHEDemitted when a comment reaches a configurable report threshold. Includes:reportedThresholdper tenant.No related issues.
These changes will impact:
What changes to the GraphQL/Database Schema does this PR introduce?
DSAConfigurationinput/output types withreportedThreshold: Intfield. Mutations/queries updated in resolvers/DSAConfiguration.ts.dsa.reportedThresholdto TenantSettings model (default 5).Does this PR introduce any new environment variables or feature flags?
None.
If any indexes were added, were they added to
INDEXES.md?No indexes added.
How do I test this PR?
pnpm run start:development:withJobs(server/).Were any tests migrated to React Testing Library?
None migrated (no RTL changes).
How do we deploy this PR?
No special steps: standard deploy. Purge admin caches if needed. New config available in tenant settings.