Skip to content

Object store 0.10.2 cx2 #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fsdvh wants to merge 2 commits into
base: object-store-0.10.2-cx1
Choose a base branch
from
Open

Object store 0.10.2 cx2 #55

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
39e187a
fix race index assignment
fsdvh Oct 18, 2024
c4c37be
comment
fsdvh Oct 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion object_store/src/upload.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,10 @@ impl WriteMultipart {
}

pub(crate) fn put_part(&mut self, part: PutPayload) {
self.tasks.spawn(self.upload.put_part(part));
// appereantly doing this inside spawn call, causes a index assignment race,
// to prevent it from happenin we do it here before spawn to ensure that the index is assigned correctly
let task = self.upload.put_part(part);
self.tasks.spawn(task);
}

/// Abort this upload, attempting to clean up any successfully uploaded parts
Expand Down