Skip to content

Replaced console logging with SLF4J#2

Open
pards wants to merge 2 commits into
coopernurse:masterfrom
pards:master
Open

Replaced console logging with SLF4J#2
pards wants to merge 2 commits into
coopernurse:masterfrom
pards:master

Conversation

@pards

@pards pards commented Mar 30, 2015

Copy link
Copy Markdown

No description provided.

@coopernurse

Copy link
Copy Markdown
Owner

Looks good. There's a few minor aesthetic things to look at:

  • tabs vs spaces -- the indentation in some of the java files isn't consistent
  • LOGGER vs logger -- I'd suggest picking one naming convention

@pards

pards commented Apr 6, 2015

Copy link
Copy Markdown
Author

Thanks James.

I'll fix the tabs vs spaces.

LOGGER vs logger - the former is the static variable, the other is an instance variable. For consistency I'll make them all static and go for the uppercase naming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants