Skip to content

fix: changelog workflow and improve test coverage - #182

Merged
coolsam726 merged 9 commits into
5.xfrom
fix/changelog-workflow-ruleset
Jun 13, 2026
Merged

fix: changelog workflow and improve test coverage#182
coolsam726 merged 9 commits into
5.xfrom
fix/changelog-workflow-ruleset

Conversation

@coolsam726

@coolsam726 coolsam726 commented Jun 13, 2026

Copy link
Copy Markdown
Owner

Summary

  • Fix the Update Changelog workflow failing under branch protection by opening an auto-merge PR instead of pushing directly to a protected branch.
  • Resolve the target branch from the release (target_commitish, with a tag-based fallback) so releases tagged from 5.x update CHANGELOG.md on 5.x instead of main.
  • Improve unit test coverage for core library code (~90% on non-command sources), fix Modules::packagePath(), and correct stub path resolution in GeneratesModularFiles.
  • Exclude src/Commands/** and unused concern traits from coverage reporting.

Test plan

  • vendor/bin/pest --ci (57 tests)
  • ./vendor/bin/phpstan analyse
  • Merge this PR
  • Re-run or re-publish the v5.3.0 release and confirm the workflow opens a PR against 5.x
  • Confirm Codecov reflects improved coverage after the next coverage workflow run

coolsam726 and others added 2 commits June 13, 2026 19:30
The release workflow was pushing directly to main, which fails under branch protection and ignored tags created from 5.x. Resolve the branch from the release target, update CHANGELOG there, and open an auto-merge PR instead.

Co-authored-by: Cursor <cursoragent@cursor.com>
Add unit tests for core modules, plugins, and service provider behavior. Exclude command scaffolding from coverage metrics, fix packagePath() and stub resolution, and extend test module helpers for Filament panels and plugins.

Co-authored-by: Cursor <cursoragent@cursor.com>
@coolsam726 coolsam726 changed the title fix: update changelog via PR on release branch fix: changelog workflow and improve test coverage Jun 13, 2026
@codecov-commenter

Copy link
Copy Markdown

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

coolsam726 and others added 7 commits June 13, 2026 19:35
Normalize stub and module output paths to the platform directory separator so generator tests and file resolution behave consistently on Windows CI runners.

Co-authored-by: Cursor <cursoragent@cursor.com>
Run Laravel 11, 12, and 13 testbench combinations on PHP 8.5 alongside the existing 8.3 and 8.4 jobs.

Co-authored-by: Cursor <cursoragent@cursor.com>
Laravel 11 does not support PHP 8.5 reliably; keep 8.5 coverage on Laravel 12 and 13 only.

Co-authored-by: Cursor <cursoragent@cursor.com>
Exercise all prompt hint match branches, stub replacement formats, view path resolution, and module prompt metadata.

Co-authored-by: Cursor <cursoragent@cursor.com>
…rovider

Add unit tests for panel discovery edge cases, plugin registration and navigation, provider auto-discovery, stub publishing, and optional package configuration paths.

Co-authored-by: Cursor <cursoragent@cursor.com>
Fail Pest coverage runs below 98% locally and in CI, and align Codecov project and patch status checks with the same target.

Co-authored-by: Cursor <cursoragent@cursor.com>
Exercise the install command endWith callback so config publishing and package setup are verified in CI.

Co-authored-by: Cursor <cursoragent@cursor.com>
@coolsam726
coolsam726 merged commit 8690379 into 5.x Jun 13, 2026
12 checks passed
@coolsam726
coolsam726 deleted the fix/changelog-workflow-ruleset branch June 13, 2026 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants