fix: custom namespace providers, panel names, and theme command - #177
Merged
Conversation
Parse provider namespaces from source files and module names from module.json so custom namespaces register correctly and panels named like Blog\App work. Document panel scoping, fix theme command filesystem injection, and add tests. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
namespacedeclaration from each provider PHP file (with path-based fallback) and resolves the module name frommodule.jsoninstead of inferring it from the namespace.ModulesPlugin::getModulePanels()uses the same resolution logic, so module names likeBlogare no longer confused with segments such asAppin custom namespaces (e.g.Blog\App\Providers\BlogPanelProvider).ModuleMakeFilamentThemeCommand::handle()assigns the injectedFilesysteminstance before use.#170 (Laravel 13)
Not addressed on
5.x. This maintenance branch targets Laravel 11–12 with Filament 4/5 and nwidart 11–13. Laravel 13 support is planned for v6 onmainperV6-ROADMAP.md.Test plan
vendor/bin/pest --ci(20 tests)vendor/bin/pint./vendor/bin/phpstan analyseModuleProviderResolutionTestcovers custom namespaces, path lookup, and provider registrationMade with Cursor